Use futures and tokio to send activities #620

Merged

elegaanz merged 4 commits from async-federation into master

elegaanz commented (Migrated from github.com)

Fixes #252

Publishing an article and having it federated to the whole fediverse only takes a few seconds now (instead of minutes before, on big Plume instances connected to many other ones).

Fixes #252 Publishing an article and having it federated to the whole fediverse only takes a few seconds now (instead of minutes before, on big Plume instances connected to many other ones).

igalic (Migrated from github.com) reviewed

igalic (Migrated from github.com) left a comment

👀

plume-common/src/activity_pub/mod.rs

igalic (Migrated from github.com) commented

is this comment still relevant?

igalic (Migrated from github.com) commented

if this fails, we panic with "new rt".??

igalic (Migrated from github.com) commented

i think we should talk about our logging strategy sometime 😅

elegaanz (Migrated from github.com) reviewed

plume-common/src/activity_pub/mod.rs

elegaanz (Migrated from github.com) commented

Not really, but it is for the background jobs in general, for the moment we just spawn them in a separate thread and that's it. I will remove it and create a more general issue.

elegaanz (Migrated from github.com) reviewed

plume-common/src/activity_pub/mod.rs

elegaanz (Migrated from github.com) commented

Hum… yes, I could probably change that. To be honest I copied this line from reqwest examples without really thinking about it 😅

Hum… yes, I could probably change that. To be honest I copied this line from reqwest examples without really thinking about it :sweat_smile:

elegaanz (Migrated from github.com) reviewed

plume-common/src/activity_pub/mod.rs

elegaanz (Migrated from github.com) commented

Indeed, we should probably use log and env_logger or something like that. Should I create an issue?

Indeed, we should probably use `log` and `env_logger` or something like that. Should I create an issue?

codecov[bot] commented (Migrated from github.com)

Codecov Report

Merging #620 into master will increase coverage by 0.08%.
The diff coverage is 26.66%.

@@            Coverage Diff             @@
##           master     #620      +/-   ##
==========================================
+ Coverage   35.28%   35.37%   +0.08%     
==========================================
  Files          68       68              
  Lines        7907     7904       -3     
  Branches     1893     1887       -6     
==========================================
+ Hits         2790     2796       +6     
+ Misses       4345     4338       -7     
+ Partials      772      770       -2

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/620?src=pr&el=h1) Report > Merging [#620](https://codecov.io/gh/Plume-org/Plume/pull/620?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/6dbc043a7e4d1757851599859683804bf36a3409?src=pr&el=desc) will **increase** coverage by `0.08%`. > The diff coverage is `26.66%`. ```diff @@ Coverage Diff @@ ## master #620 +/- ## ========================================== + Coverage 35.28% 35.37% +0.08% ========================================== Files 68 68 Lines 7907 7904 -3 Branches 1893 1887 -6 ========================================== + Hits 2790 2796 +6 + Misses 4345 4338 -7 + Partials 772 770 -2 ```

trinity-1686a reviewed

trinity-1686a left a comment

Owner

👀

plume-common/src/activity_pub/mod.rs

trinity-1686a commented

Owner

I think this print should be done in the map just under, otherwise output could get mixed quickly, making both logs useless

plume-common/src/activity_pub/mod.rs

trinity-1686a commented

Owner

(what is that comma for?)

elegaanz (Migrated from github.com) reviewed

plume-common/src/activity_pub/mod.rs

elegaanz (Migrated from github.com) commented

(no idea, I will remove it)

elegaanz (Migrated from github.com) reviewed

plume-common/src/activity_pub/mod.rs

elegaanz (Migrated from github.com) commented

Actually, it is added by cargo-fmt, because this whole expression is the argument of a function.

trinity-1686a reviewed

plume-common/src/activity_pub/mod.rs

trinity-1686a commented

Owner

okay...

trinity-1686a approved these changes

Reviewers

trinity-1686a approved these changes

The pull request has been merged as 7ea4acc289.

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b async-federation master

git pull origin async-federation

Step 2:

Merge the changes and update on Forgejo.

git checkout master

git merge --no-ff async-federation

git push origin master

No reviewers

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Loading…

There is no content yet.

Labels Milestones

Use futures and tokio to send activities #620

Codecov Report

Reviewers

Step 1:

Step 2: