delete notification on user deletion #658

已合并

Plume_migration_agent 于将 5 次代码提交从 bugfix/651 合并至 master

trinity-1686a 评论于

所有者

fix #651

before merging, I'd like to add a regression test

fix #651 before merging, I'd like to add a regression test

👍 1

codecov[bot] 评论于 (从 github.com 迁移)

Codecov Report

Merging #658 into master will increase coverage by 0.58%.
The diff coverage is 70%.

@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
+ Coverage   34.58%   35.17%   +0.58%     
==========================================
  Files          68       68              
  Lines        8020     7952      -68     
  Branches     1890     1893       +3     
==========================================
+ Hits         2774     2797      +23     
+ Misses       4468     4374      -94     
- Partials      778      781       +3

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/658?src=pr&el=h1) Report > Merging [#658](https://codecov.io/gh/Plume-org/Plume/pull/658?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/d46af6fe5bb472d0aa9435520690c3b94a3ec577?src=pr&el=desc) will **increase** coverage by `0.58%`. > The diff coverage is `70%`. ```diff @@ Coverage Diff @@ ## master #658 +/- ## ========================================== + Coverage 34.58% 35.17% +0.58% ========================================== Files 68 68 Lines 8020 7952 -68 Branches 1890 1893 +3 ========================================== + Hits 2774 2797 +23 + Misses 4468 4374 -94 - Partials 778 781 +3 ```

elegaanz (从 github.com 迁移) 请求变更

plume-models/src/notifications.rs

elegaanz (从 github.com 迁移) 评论于

object_id is the ID of the Follow object actually.

`object_id` is the ID of the `Follow` object actually.

elegaanz (从 github.com 迁移) 评审于

elegaanz (从 github.com 迁移) 留下了一条评论

If the tests pass, you can merge!

trinity-1686a 评论于

发布者

所有者

this has been stall for a bit, and I don't have time to fix the CI (the problem is not related to the fix, but to the way integration tests are run). I'll revert latests commit so we can merge it as is

igalic (从 github.com 迁移) 于批准此合并请求

igalic (从 github.com 迁移) 留下了一条评论

👍

评审人

该合并请求已作为 12c80f9981 被合并。

你也可以查看命令行指令

第一步:

从你的仓库中签出一个新的分支并测试变更。

git checkout -b bugfix/651 master

git pull origin bugfix/651

第二步：

合并变更并更新到 Forgejo 上

git checkout master

git merge --no-ff bugfix/651

git push origin master

登录并参与到对话中。

无审核者

未选择里程碑

未指派成员

2 名参与者

通知

到期时间

到期日期无效或超出范围。请使用 'yyyy-mm-dd' 格式。

未设置到期时间。

依赖工单

没有设置依赖项。

正在加载...

这个人很懒，什么都没留下。

标签 里程碑

delete notification on user deletion #658

Codecov Report

评审人

第一步:

第二步：

标签里程碑