order media so that latest added are top #660

Merge aplicado
Plume_migration_agent aplicou merge dos 2 commits de feature/621 em master 5 anos atrás
Proprietário

partial fix for #621

partial fix for #621
codecov[bot] comentou 5 anos atrás (Migrado de github.com)

Codecov Report

Merging #660 into master will increase coverage by 0.04%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
+ Coverage   35.11%   35.15%   +0.04%     
==========================================
  Files          68       68              
  Lines        7943     7950       +7     
  Branches     1889     1889              
==========================================
+ Hits         2789     2795       +6     
- Misses       4374     4375       +1     
  Partials      780      780
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/660?src=pr&el=h1) Report > Merging [#660](https://codecov.io/gh/Plume-org/Plume/pull/660?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/935d331e971bc19019a4cbc271b3a59719b6be93?src=pr&el=desc) will **increase** coverage by `0.04%`. > The diff coverage is `85.71%`. ```diff @@ Coverage Diff @@ ## master #660 +/- ## ========================================== + Coverage 35.11% 35.15% +0.04% ========================================== Files 68 68 Lines 7943 7950 +7 Branches 1889 1889 ========================================== + Hits 2789 2795 +6 - Misses 4374 4375 +1 Partials 780 780 ```
igalic (Migrado de github.com) revisou 5 anos atrás
igalic (Migrado de github.com) deixou um comentário

@ -66,0 +67,4 @@
medias::table
.filter(medias::owner_id.eq(owner))
.order(medias::id.desc())
.load::<Self>(conn)
igalic (Migrado de github.com) comentou 5 anos atrás

is this guaranteed to be such?
do we have a create date anywhere?

is this guaranteed to be such? do we have a create date anywhere?
trinity-1686a revisou 5 anos atrás
@ -66,0 +67,4 @@
medias::table
.filter(medias::owner_id.eq(owner))
.order(medias::id.desc())
.load::<Self>(conn)
Autor
Proprietário

we don't have date, and the ids we use are monotonic counter, unless we overflow that 64b signed counter (not likely to happen)

we don't have date, and the ids we use are monotonic counter, unless we overflow that 64b signed counter (not likely to happen)
igalic (Migrado de github.com) revisou 5 anos atrás
@ -66,0 +67,4 @@
medias::table
.filter(medias::owner_id.eq(owner))
.order(medias::id.desc())
.load::<Self>(conn)
igalic (Migrado de github.com) comentou 5 anos atrás

i wonder if anyone expects that editing a media pushes it to the top again…

i wonder if anyone expects that editing a media pushes it to the top again…
elegaanz (Migrado de github.com) revisou 5 anos atrás
@ -66,0 +67,4 @@
medias::table
.filter(medias::owner_id.eq(owner))
.order(medias::id.desc())
.load::<Self>(conn)
elegaanz (Migrado de github.com) comentou 5 anos atrás

We can't edit media information for the moment, so…

We can't edit media information for the moment, so…
igalic (Migrado de github.com) revisou 5 anos atrás
@ -66,0 +67,4 @@
medias::table
.filter(medias::owner_id.eq(owner))
.order(medias::id.desc())
.load::<Self>(conn)
igalic (Migrado de github.com) comentou 5 anos atrás

well then… pushes [resolve] button

well then… *pushes [resolve] button*
elegaanz (Migrado de github.com) revisou 5 anos atrás
elegaanz (Migrado de github.com) deixou um comentário

Ideally, it should be done for the paginated version too, so that /media lists them in the correct order.

Ideally, it should be done for the paginated version too, so that `/media` lists them in the correct order.
igalic (Migrado de github.com) aprovou estas alterações 5 anos atrás
igalic (Migrado de github.com) deixou um comentário

👍

:+1:

Revisores

O pull request teve merge aplicado como d46af6fe5b.
Você também pode ver as instruções para a linha de comandos.

Passo 1:

No repositório do seu projeto, crie um novo branch e teste as alterações.
git checkout -b feature/621 master
git pull origin feature/621

Passo 2:

Faça merge das alterações e atualize no Forgejo.
git checkout master
git merge --no-ff feature/621
git push origin master
Acesse para participar desta conversação.
Sem revisor
Sem marco
Sem responsável
2 participante(s)
Notificações
Data limite
A data limite é inválida ou está fora do intervalo. Por favor, use o formato 'dd/mm/aaaa'.

Data limite não informada.

Dependências

Nenhuma dependência definida.

Referência: Plume/Plume#660
Carregando…
Ainda não há conteúdo.