Amend margins on mobile displays #662

Closed

marek-lach wants to merge 70 commits from marek-lach-patch-1-2 into master

marek-lach commented (Migrated from github.com)

Fixes #655 and also most of #604.

Edit: Better addressed by #663. Closing this issue now.

Fixes #655 and also most of #604. **Edit:** Better addressed by #663. Closing this issue now.

codecov[bot] commented (Migrated from github.com)

Codecov Report

Merging #662 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #662   +/-   ##
=======================================
  Coverage   34.58%   34.58%           
=======================================
  Files          68       68           
  Lines        8020     8020           
  Branches     1890     1890           
=======================================
  Hits         2774     2774           
  Misses       4468     4468           
  Partials      778      778

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/662?src=pr&el=h1) Report > Merging [#662](https://codecov.io/gh/Plume-org/Plume/pull/662?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/d46af6fe5bb472d0aa9435520690c3b94a3ec577?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #662 +/- ## ======================================= Coverage 34.58% 34.58% ======================================= Files 68 68 Lines 8020 8020 Branches 1890 1890 ======================================= Hits 2774 2774 Misses 4468 4468 Partials 778 778 ```

codecov[bot] commented (Migrated from github.com)

Codecov Report

Merging #662 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #662   +/-   ##
=======================================
  Coverage   34.58%   34.58%           
=======================================
  Files          68       68           
  Lines        8020     8020           
  Branches     1890     1890           
=======================================
  Hits         2774     2774           
  Misses       4468     4468           
  Partials      778      778

elegaanz commented (Migrated from github.com)

Looks like it is too much now…

Looks like it is too much now… ![image](https://user-images.githubusercontent.com/16254623/63952479-f6b19000-ca7f-11e9-81f8-1d8977ec99bf.png) ![image](https://user-images.githubusercontent.com/16254623/63952499-fc0eda80-ca7f-11e9-8356-42bb1e74f464.png)

👀 1

elegaanz commented (Migrated from github.com)

Still the same for me… 😕 I can try to have a look tomorrow or on Saturday if you want.

Still the same for me… :confused: I can try to have a look tomorrow or on Saturday if you want.

marek-lach commented (Migrated from github.com)

I'll see what I can do...

marek-lach commented (Migrated from github.com)

@AnaGelez All tested and seems to work well on my end.

elegaanz commented (Migrated from github.com)

The article content is indeed better (maybe even a bit too much), but some elements that shouldn't have margins now have (article cover/heading, and all the info at the bottom from the license to the comment area). 😕

marek-lach commented (Migrated from github.com)

The article content is indeed better (maybe even a bit too much), but some elements that shouldn't have margins now have (article cover/heading, and all the info at the bottom from the license to the comment area). 😕

All of these issues should be ok now.

> The article content is indeed better (maybe even a bit too much), but some elements that shouldn't have margins now have (article cover/heading, and all the info at the bottom from the license to the comment area). 😕 All of these issues should be ok now.

marek-lach commented (Migrated from github.com)

Not really sure why the article cover image isn't fully scaled to be honest...

Edit: fixed. All works well now. This PR is finally done :-)

Not really sure why the article cover image isn't fully scaled to be honest... **Edit:** fixed. All works well now. This PR is finally done :-)

elegaanz (Migrated from github.com) requested changes

elegaanz (Migrated from github.com) left a comment

I'm sorry but I still have issues… I can go into details if you want, but I also made another PR that should fix these issues, because I felt you were struggling with CSS here… So you can either tell me if #663 works for you, or I can tell you what is still wrong with this one, and you cant try to fix it if you really want to do it yourself.

marek-lach commented (Migrated from github.com)

I felt you were struggling with CSS here

You are right. It's a lot of guess work for me, I am not really natural at it :-)

> I felt you were struggling with CSS here You are right. It's a lot of guess work for me, I am not really natural at it :-)

marek-lach (Migrated from github.com) reviewed

assets/themes/default/_forms.scss

marek-lach (Migrated from github.com) commented

This bit here seems to make the article meta less squashed than before on small screens, I think?

Before:
Screenshot 2019-09-01 at 19 23 09

After #662:

May be worth replicating in #663 if you want...

This bit here seems to make the _article meta_ less squashed than before on small screens, I think? Before: <img width="438" alt="Screenshot 2019-09-01 at 19 23 09" src="https://user-images.githubusercontent.com/45913977/64079905-1e0d9480-ccee-11e9-9433-7ea082f6f757.png"> After #662: <img width="440" alt="Screenshot 2019-09-01 at 19 23 44" src="https://user-images.githubusercontent.com/45913977/64079909-2f56a100-ccee-11e9-8231-0e97fd267362.png"> May be worth replicating in #663 if you want...

elegaanz (Migrated from github.com) reviewed

assets/themes/default/_forms.scss

elegaanz (Migrated from github.com) commented

I'm not sure these lines apply on article meta section, as it doesn't have the split class too (it is used only for the license/tags part, not the rest). But I have something similar to that in my PR. Thanks anyway!

I'm not sure these lines apply on *article meta* section, as it doesn't have the `split` class too (it is used only for the license/tags part, not the rest). But I have something similar to that in my PR. Thanks anyway!

Reviewers

This pull request cannot be reopened because the branch was deleted.

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b marek-lach-patch-1-2 master

git pull origin marek-lach-patch-1-2

Step 2:

Merge the changes and update on Forgejo.

git checkout master

git merge --no-ff marek-lach-patch-1-2

git push origin master

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Loading…

There is no content yet.

Labels Milestones

Amend margins on mobile displays #662

Codecov Report

Codecov Report

Reviewers

Step 1:

Step 2: