Plume/Plume
9
18
Fork 24
Code Issues 177 Pull requests 8 Releases 8 Wiki Activity

Amend margins on mobile displays #662

Closed
marek-lach wants to merge 70 commits from marek-lach-patch-1-2 into master
pull from: marek-lach-patch-1-2
merge into: Plume:master
Conversation 10 Commits 70 Files changed 3 +11 -9
marek-lach commented 2019-08-29 14:09:12 +00:00 (Migrated from github.com)
Copy link

Fixes #655 and also most of #604.

Edit: Better addressed by #663. Closing this issue now.

Fixes #655 and also most of #604. **Edit:** Better addressed by #663. Closing this issue now.
codecov[bot] commented 2019-08-29 14:42:59 +00:00 (Migrated from github.com)
Copy link

Codecov Report

Merging #662 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #662   +/-   ##
=======================================
  Coverage   34.58%   34.58%           
=======================================
  Files          68       68           
  Lines        8020     8020           
  Branches     1890     1890           
=======================================
  Hits         2774     2774           
  Misses       4468     4468           
  Partials      778      778
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/662?src=pr&el=h1) Report > Merging [#662](https://codecov.io/gh/Plume-org/Plume/pull/662?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/d46af6fe5bb472d0aa9435520690c3b94a3ec577?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #662 +/- ## ======================================= Coverage 34.58% 34.58% ======================================= Files 68 68 Lines 8020 8020 Branches 1890 1890 ======================================= Hits 2774 2774 Misses 4468 4468 Partials 778 778 ```
codecov[bot] commented 2019-08-29 14:43:02 +00:00 (Migrated from github.com)
Copy link

Codecov Report

Merging #662 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #662   +/-   ##
=======================================
  Coverage   34.58%   34.58%           
=======================================
  Files          68       68           
  Lines        8020     8020           
  Branches     1890     1890           
=======================================
  Hits         2774     2774           
  Misses       4468     4468           
  Partials      778      778
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/662?src=pr&el=h1) Report > Merging [#662](https://codecov.io/gh/Plume-org/Plume/pull/662?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/d46af6fe5bb472d0aa9435520690c3b94a3ec577?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #662 +/- ## ======================================= Coverage 34.58% 34.58% ======================================= Files 68 68 Lines 8020 8020 Branches 1890 1890 ======================================= Hits 2774 2774 Misses 4468 4468 Partials 778 778 ```
elegaanz commented 2019-08-29 15:11:12 +00:00 (Migrated from github.com)
Copy link

Looks like it is too much now…

image

image

Looks like it is too much now… ![image](https://user-images.githubusercontent.com/16254623/63952479-f6b19000-ca7f-11e9-81f8-1d8977ec99bf.png) ![image](https://user-images.githubusercontent.com/16254623/63952499-fc0eda80-ca7f-11e9-8356-42bb1e74f464.png)
👀 1
elegaanz commented 2019-08-29 19:35:24 +00:00 (Migrated from github.com)
Copy link

Still the same for me… 😕 I can try to have a look tomorrow or on Saturday if you want.

Still the same for me… :confused: I can try to have a look tomorrow or on Saturday if you want.
marek-lach commented 2019-08-29 20:09:29 +00:00 (Migrated from github.com)
Copy link

I'll see what I can do...

I'll see what I can do...
marek-lach commented 2019-08-30 13:33:11 +00:00 (Migrated from github.com)
Copy link

@AnaGelez All tested and seems to work well on my end.

@AnaGelez All tested and seems to work well on my end.
elegaanz commented 2019-08-30 15:18:36 +00:00 (Migrated from github.com)
Copy link

The article content is indeed better (maybe even a bit too much), but some elements that shouldn't have margins now have (article cover/heading, and all the info at the bottom from the license to the comment area). 😕

The article content is indeed better (maybe even a bit too much), but some elements that shouldn't have margins now have (article cover/heading, and all the info at the bottom from the license to the comment area). :confused:
marek-lach commented 2019-08-31 13:29:14 +00:00 (Migrated from github.com)
Copy link

The article content is indeed better (maybe even a bit too much), but some elements that shouldn't have margins now have (article cover/heading, and all the info at the bottom from the license to the comment area). 😕

All of these issues should be ok now.

> The article content is indeed better (maybe even a bit too much), but some elements that shouldn't have margins now have (article cover/heading, and all the info at the bottom from the license to the comment area). 😕 All of these issues should be ok now.
marek-lach commented 2019-08-31 18:02:33 +00:00 (Migrated from github.com)
Copy link

Not really sure why the article cover image isn't fully scaled to be honest...

Edit: fixed. All works well now. This PR is finally done :-)

Not really sure why the article cover image isn't fully scaled to be honest... **Edit:** fixed. All works well now. This PR is finally done :-)
elegaanz (Migrated from github.com) requested changes 2019-09-01 17:01:17 +00:00
elegaanz (Migrated from github.com) left a comment
Copy link

I'm sorry but I still have issues… I can go into details if you want, but I also made another PR that should fix these issues, because I felt you were struggling with CSS here… So you can either tell me if #663 works for you, or I can tell you what is still wrong with this one, and you cant try to fix it if you really want to do it yourself.

I'm sorry but I still have issues… I can go into details if you want, but I also made another PR that should fix these issues, because I felt you were struggling with CSS here… So you can either tell me if #663 works for you, or I can tell you what is still wrong with this one, and you cant try to fix it if you really want to do it yourself.
marek-lach commented 2019-09-01 17:19:44 +00:00 (Migrated from github.com)
Copy link

I felt you were struggling with CSS here

You are right. It's a lot of guess work for me, I am not really natural at it :-)

> I felt you were struggling with CSS here You are right. It's a lot of guess work for me, I am not really natural at it :-)
marek-lach (Migrated from github.com) reviewed 2019-09-01 17:25:55 +00:00
assets/themes/default/_forms.scss
marek-lach (Migrated from github.com) commented 2019-09-01 17:25:55 +00:00
Copy link

This bit here seems to make the article meta less squashed than before on small screens, I think?

Before:
Screenshot 2019-09-01 at 19 23 09

After #662:

Screenshot 2019-09-01 at 19 23 44

May be worth replicating in #663 if you want...

This bit here seems to make the _article meta_ less squashed than before on small screens, I think? Before: <img width="438" alt="Screenshot 2019-09-01 at 19 23 09" src="https://user-images.githubusercontent.com/45913977/64079905-1e0d9480-ccee-11e9-9433-7ea082f6f757.png"> After #662: <img width="440" alt="Screenshot 2019-09-01 at 19 23 44" src="https://user-images.githubusercontent.com/45913977/64079909-2f56a100-ccee-11e9-8231-0e97fd267362.png"> May be worth replicating in #663 if you want...
elegaanz (Migrated from github.com) reviewed 2019-09-01 17:29:45 +00:00
assets/themes/default/_forms.scss
elegaanz (Migrated from github.com) commented 2019-09-01 17:29:45 +00:00
Copy link

I'm not sure these lines apply on article meta section, as it doesn't have the split class too (it is used only for the license/tags part, not the rest). But I have something similar to that in my PR. Thanks anyway!

I'm not sure these lines apply on *article meta* section, as it doesn't have the `split` class too (it is used only for the license/tags part, not the rest). But I have something similar to that in my PR. Thanks anyway!

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
elegaanz
Labels
Clear labels   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

No labels
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#662
No description provided.
Delete branch "marek-lach-patch-1-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?