elegaanz commented

(Migrated from github.com)

The overflowing header bug seems to be fixed. Fixes #652
There are now small margins everywhere (no more big margins, no more non-existent margins, and this on every page (article, editors, home, etc)). Fixes #655 and the second point of #604
The "header" of the advanced editor is now more easily usable (fix for this comment: https://github.com/Plume-org/Plume/issues/604#issuecomment-497546958)

cc @marek-lach tell me if this works for you.

- The overflowing header bug seems to be fixed. Fixes #652 - There are now small margins everywhere (no more big margins, no more non-existent margins, and this on every page (article, editors, home, etc)). Fixes #655 and the second point of #604 - The "header" of the advanced editor is now more easily usable (fix for this comment: https://github.com/Plume-org/Plume/issues/604#issuecomment-497546958) cc @marek-lach tell me if this works for you.

❤️ 1

codecov[bot] commented

2019-09-01 17:11:02 +00:00

(Migrated from github.com)

Codecov Report

Merging #663 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #663   +/-   ##
=======================================
  Coverage   39.32%   39.32%           
=======================================
  Files          72       72           
  Lines        9497     9497           
  Branches     2265     2265           
=======================================
  Hits         3735     3735           
  Misses       4697     4697           
  Partials     1065     1065

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/663?src=pr&el=h1) Report > Merging [#663](https://codecov.io/gh/Plume-org/Plume/pull/663?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/e53574970cb98da91b177124b4886084984dee45?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #663 +/- ## ======================================= Coverage 39.32% 39.32% ======================================= Files 72 72 Lines 9497 9497 Branches 2265 2265 ======================================= Hits 3735 3735 Misses 4697 4697 Partials 1065 1065 ```

elegaanz commented

2019-09-01 18:21:27 +00:00

(Migrated from github.com)

I deployed this branch to https://baptiste.gelez.xyz because for some reason Plume CI failed…

Aldarone commented

2019-09-11 07:23:40 +00:00

(Migrated from github.com)

Would be nice if a touch on the burger menu button closed it back when it's open.

👍 1

igalic commented

2019-09-11 08:21:43 +00:00

(Migrated from github.com)

Would be nice if a touch on the burger menu button closed it back when it's open.

i did say that when @AnaGelez was designing this the first time around…

> Would be nice if a touch on the burger menu button closed it back when it's open. i did say that when @AnaGelez was designing this the first time around…

kiwii commented

2020-08-11 18:14:19 +00:00

Owner

Closing and re-opening, as this PR targets master and not main.

kiwii closed this pull request

2020-08-11 18:14:19 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Rows
Columns

Small improvements to the mobile interface #663

Codecov Report

Pull request closed