Add environmental variable to control path of media #683

Fusionado

epsilon-phase fusionados 1 commits de Media-path en master

epsilon-phase comentado (Migrado desde github.com)

This was a request made on the matrix chat that will make it possible to release a snap version, that environmental variable being MEDIA_UPLOAD_DIRECTORY

This was a request made on the matrix chat that will make it possible to release a snap version, that environmental variable being `MEDIA_UPLOAD_DIRECTORY`

codecov[bot] comentado (Migrado desde github.com)

Codecov Report

Merging #683 into master will decrease coverage by 0.03%.
The diff coverage is 21.05%.

@@            Coverage Diff            @@
##           master    #683      +/-   ##
=========================================
- Coverage   39.83%   39.8%   -0.04%     
=========================================
  Files          72      72              
  Lines        9368    9383      +15     
  Branches     2219    2219              
=========================================
+ Hits         3732    3735       +3     
- Misses       4580    4592      +12     
  Partials     1056    1056

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/683?src=pr&el=h1) Report > Merging [#683](https://codecov.io/gh/Plume-org/Plume/pull/683?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/dd6d39135e71cd4f4f22befb45da46d89d39ae33?src=pr&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `21.05%`. ```diff @@ Coverage Diff @@ ## master #683 +/- ## ========================================= - Coverage 39.83% 39.8% -0.04% ========================================= Files 72 72 Lines 9368 9383 +15 Branches 2219 2219 ========================================= + Hits 3732 3735 +3 - Misses 4580 4592 +12 Partials 1056 1056 ```

RAOF (Migrado desde github.com) revisado

RAOF (Migrado desde github.com) dejó un comentario

This looks correct to me; I'm not familiar with Rocket's #[get()] routing stuff, so someone else should check that this is correct.

I'll give it a test! Thanks!

This looks correct to me; I'm not familiar with Rocket's `#[get()]` routing stuff, so someone else should check that this is correct. I'll give it a test! Thanks!

igalic (Migrado desde github.com) revisado

igalic (Migrado desde github.com) dejó un comentario

👀

src/routes/medias.rs

igalic (Migrado desde github.com) comentado

is this supposed to be deterministic?

epsilon-phase (Migrado desde github.com) revisado

src/routes/medias.rs

epsilon-phase (Migrado desde github.com) comentado

Is it deterministic? It seems to come up with new GUIDs each piece we upload.
(We don't think we quite understand)

Is it deterministic? It seems to come up with new GUIDs each piece we upload. (We don't think we quite understand)

igalic (Migrado desde github.com) revisado

src/routes/medias.rs

igalic (Migrado desde github.com) comentado

aah, never mind, i was thinking of something else
(the deterministially random id we use per release for our assets)

aah, never mind, i was thinking of something else (the deterministially random id we use per release for *our* assets)

trinity-1686a revisado

trinity-1686a dejó un comentario

Propietario

I haven't tested yet, but apart from a minor path mistake, it looks good to me 🙂

I haven't tested yet, but apart from a minor path mistake, it looks good to me :slightly_smiling_face:

plume-models/src/medias.rs

trinity-1686a comentado

Propietario

the media part is already included in the default value of media_directory (static/media). I don't know if it should be removed from here or from there (it depends on how custom directory should appear), but I think there is one too much

the `media` part is already included in the default value of media_directory (`static/media`). I don't know if it should be removed from here or from there (it depends on how custom directory should appear), but I think there is one too much

epsilon-phase (Migrado desde github.com) revisado

plume-models/src/medias.rs

epsilon-phase (Migrado desde github.com) comentado

Oh, thanks for the catch.

RAOF comentado (Migrado desde github.com)

I've built a snap from this locally, setting the new MEDIA_UPLOAD_DIRECTORY appropriately, and it works!

Once this lands I'll push a PR for the snapcraft metadata and we'll have a fully-functional snap that I can then document! 😁

I've built a snap from this locally, setting the new `MEDIA_UPLOAD_DIRECTORY` appropriately, and it works! Once this lands I'll push a PR for the snapcraft metadata and we'll have a fully-functional snap that I can then document! :grin:

🎉 3

elegaanz (Migrado desde github.com) aprobado estos cambios

elegaanz (Migrado desde github.com) dejó un comentario

Looks good to me! Thank you for your help! 👍

Looks good to me! Thank you for your help! :+1:

Revisores

El Pull Request se ha fusionado como 866465c603.

También puede ver instrucciones de línea de comandos.

Paso 1:

Desde el repositorio de su proyecto, revisa una nueva rama y prueba los cambios.

git checkout -b Media-path master

git pull origin Media-path

Paso 2:

Combine los cambios y actualice en Forgejo.

git checkout master

git merge --no-ff Media-path

git push origin master

Inicie sesión para unirse a esta conversación.

No hay revisores

Sin Milestone

No asignados

2 participantes

Notificaciones

Fecha de vencimiento

La fecha de vencimiento es inválida o está fuera de rango. Por favor utilice el formato 'aaaa-mm-dd'.

Sin fecha de vencimiento.

Dependencias

No se han establecido dependencias.

Cargando…

Aún no existe contenido.

Etiquetas Hitos

Add environmental variable to control path of media #683

Codecov Report

Revisores

Paso 1:

Paso 2: