Add environmental variable to control path of media #683

Yhdistetty

epsilon-phase yhdistetty 1 committia lähteestä Media-path kohteeseen master

epsilon-phase kommentoi (Migrated from github.com)

This was a request made on the matrix chat that will make it possible to release a snap version, that environmental variable being MEDIA_UPLOAD_DIRECTORY

This was a request made on the matrix chat that will make it possible to release a snap version, that environmental variable being `MEDIA_UPLOAD_DIRECTORY`

codecov[bot] kommentoi (Migrated from github.com)

Codecov Report

Merging #683 into master will decrease coverage by 0.03%.
The diff coverage is 21.05%.

@@            Coverage Diff            @@
##           master    #683      +/-   ##
=========================================
- Coverage   39.83%   39.8%   -0.04%     
=========================================
  Files          72      72              
  Lines        9368    9383      +15     
  Branches     2219    2219              
=========================================
+ Hits         3732    3735       +3     
- Misses       4580    4592      +12     
  Partials     1056    1056

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/683?src=pr&el=h1) Report > Merging [#683](https://codecov.io/gh/Plume-org/Plume/pull/683?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/dd6d39135e71cd4f4f22befb45da46d89d39ae33?src=pr&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `21.05%`. ```diff @@ Coverage Diff @@ ## master #683 +/- ## ========================================= - Coverage 39.83% 39.8% -0.04% ========================================= Files 72 72 Lines 9368 9383 +15 Branches 2219 2219 ========================================= + Hits 3732 3735 +3 - Misses 4580 4592 +12 Partials 1056 1056 ```

RAOF (Migrated from github.com) reviewed

RAOF (Migrated from github.com) jätti kommentin

This looks correct to me; I'm not familiar with Rocket's #[get()] routing stuff, so someone else should check that this is correct.

I'll give it a test! Thanks!

This looks correct to me; I'm not familiar with Rocket's `#[get()]` routing stuff, so someone else should check that this is correct. I'll give it a test! Thanks!

igalic (Migrated from github.com) reviewed

igalic (Migrated from github.com) jätti kommentin

👀

src/routes/medias.rs

igalic (Migrated from github.com) kommentoi

is this supposed to be deterministic?

epsilon-phase (Migrated from github.com) reviewed

src/routes/medias.rs

epsilon-phase (Migrated from github.com) kommentoi

Is it deterministic? It seems to come up with new GUIDs each piece we upload.
(We don't think we quite understand)

Is it deterministic? It seems to come up with new GUIDs each piece we upload. (We don't think we quite understand)

igalic (Migrated from github.com) reviewed

src/routes/medias.rs

igalic (Migrated from github.com) kommentoi

aah, never mind, i was thinking of something else
(the deterministially random id we use per release for our assets)

aah, never mind, i was thinking of something else (the deterministially random id we use per release for *our* assets)

trinity-1686a reviewed

trinity-1686a jätti kommentin

Omistaja

I haven't tested yet, but apart from a minor path mistake, it looks good to me 🙂

I haven't tested yet, but apart from a minor path mistake, it looks good to me :slightly_smiling_face:

plume-models/src/medias.rs

trinity-1686a kommentoi

Omistaja

the media part is already included in the default value of media_directory (static/media). I don't know if it should be removed from here or from there (it depends on how custom directory should appear), but I think there is one too much

the `media` part is already included in the default value of media_directory (`static/media`). I don't know if it should be removed from here or from there (it depends on how custom directory should appear), but I think there is one too much

epsilon-phase (Migrated from github.com) reviewed

plume-models/src/medias.rs

epsilon-phase (Migrated from github.com) kommentoi

Oh, thanks for the catch.

RAOF kommentoi (Migrated from github.com)

I've built a snap from this locally, setting the new MEDIA_UPLOAD_DIRECTORY appropriately, and it works!

Once this lands I'll push a PR for the snapcraft metadata and we'll have a fully-functional snap that I can then document! 😁

I've built a snap from this locally, setting the new `MEDIA_UPLOAD_DIRECTORY` appropriately, and it works! Once this lands I'll push a PR for the snapcraft metadata and we'll have a fully-functional snap that I can then document! :grin:

🎉 3

elegaanz (Migrated from github.com) hyväksyi nämä muutokset

elegaanz (Migrated from github.com) jätti kommentin

Looks good to me! Thank you for your help! 👍

Looks good to me! Thank you for your help! :+1:

Reviewers

The pull request has been merged as 866465c603.

You can also view command line instructions.

Vaihe 1:

From your project repository, check out a new branch and test the changes.

git checkout -b Media-path master

git pull origin Media-path

Vaihe 2:

Merge the changes and update on Forgejo.

git checkout master

git merge --no-ff Media-path

git push origin master

No reviewers

Ei merkkipaalua

Ei käsittelijää

2 osallistujaa

Ilmoitukset

Määräpäivä

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

Määräpäivää ei asetettu.

Riippuvuudet

Riippuvuuksia ei asetettu.

Ladataan…

Sisältöä ei vielä ole.

Tunnisteet Merkkipaalut

Add environmental variable to control path of media #683

Codecov Report

Reviewers

Vaihe 1:

Vaihe 2: