Add environmental variable to control path of media #683

Samengevoegd

epsilon-phase heeft 1 commits samengevoegd van Media-path naar master

epsilon-phase reageerde (Gemigreerd van github.com)

This was a request made on the matrix chat that will make it possible to release a snap version, that environmental variable being MEDIA_UPLOAD_DIRECTORY

This was a request made on the matrix chat that will make it possible to release a snap version, that environmental variable being `MEDIA_UPLOAD_DIRECTORY`

codecov[bot] reageerde (Gemigreerd van github.com)

Codecov Report

Merging #683 into master will decrease coverage by 0.03%.
The diff coverage is 21.05%.

@@            Coverage Diff            @@
##           master    #683      +/-   ##
=========================================
- Coverage   39.83%   39.8%   -0.04%     
=========================================
  Files          72      72              
  Lines        9368    9383      +15     
  Branches     2219    2219              
=========================================
+ Hits         3732    3735       +3     
- Misses       4580    4592      +12     
  Partials     1056    1056

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/683?src=pr&el=h1) Report > Merging [#683](https://codecov.io/gh/Plume-org/Plume/pull/683?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/dd6d39135e71cd4f4f22befb45da46d89d39ae33?src=pr&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `21.05%`. ```diff @@ Coverage Diff @@ ## master #683 +/- ## ========================================= - Coverage 39.83% 39.8% -0.04% ========================================= Files 72 72 Lines 9368 9383 +15 Branches 2219 2219 ========================================= + Hits 3732 3735 +3 - Misses 4580 4592 +12 Partials 1056 1056 ```

RAOF (Gemigreerd van github.com) beoordeeld

RAOF (Gemigreerd van github.com) heeft een reactie achtergelaten

This looks correct to me; I'm not familiar with Rocket's #[get()] routing stuff, so someone else should check that this is correct.

I'll give it a test! Thanks!

This looks correct to me; I'm not familiar with Rocket's `#[get()]` routing stuff, so someone else should check that this is correct. I'll give it a test! Thanks!

igalic (Gemigreerd van github.com) beoordeeld

igalic (Gemigreerd van github.com) heeft een reactie achtergelaten

👀

src/routes/medias.rs

igalic (Gemigreerd van github.com) reageerde

is this supposed to be deterministic?

epsilon-phase (Gemigreerd van github.com) beoordeeld

src/routes/medias.rs

epsilon-phase (Gemigreerd van github.com) reageerde

Is it deterministic? It seems to come up with new GUIDs each piece we upload.
(We don't think we quite understand)

Is it deterministic? It seems to come up with new GUIDs each piece we upload. (We don't think we quite understand)

igalic (Gemigreerd van github.com) beoordeeld

src/routes/medias.rs

igalic (Gemigreerd van github.com) reageerde

aah, never mind, i was thinking of something else
(the deterministially random id we use per release for our assets)

aah, never mind, i was thinking of something else (the deterministially random id we use per release for *our* assets)

trinity-1686a beoordeeld

trinity-1686a heeft een reactie achtergelaten

Eigenaar

I haven't tested yet, but apart from a minor path mistake, it looks good to me 🙂

I haven't tested yet, but apart from a minor path mistake, it looks good to me :slightly_smiling_face:

plume-models/src/medias.rs

trinity-1686a reageerde

Eigenaar

the media part is already included in the default value of media_directory (static/media). I don't know if it should be removed from here or from there (it depends on how custom directory should appear), but I think there is one too much

the `media` part is already included in the default value of media_directory (`static/media`). I don't know if it should be removed from here or from there (it depends on how custom directory should appear), but I think there is one too much

epsilon-phase (Gemigreerd van github.com) beoordeeld

plume-models/src/medias.rs

epsilon-phase (Gemigreerd van github.com) reageerde

Oh, thanks for the catch.

RAOF reageerde (Gemigreerd van github.com)

I've built a snap from this locally, setting the new MEDIA_UPLOAD_DIRECTORY appropriately, and it works!

Once this lands I'll push a PR for the snapcraft metadata and we'll have a fully-functional snap that I can then document! 😁

I've built a snap from this locally, setting the new `MEDIA_UPLOAD_DIRECTORY` appropriately, and it works! Once this lands I'll push a PR for the snapcraft metadata and we'll have a fully-functional snap that I can then document! :grin:

🎉 3

elegaanz (Gemigreerd van github.com) heeft deze veranderingen goedgekeurd

elegaanz (Gemigreerd van github.com) heeft een reactie achtergelaten

Looks good to me! Thank you for your help! 👍

Looks good to me! Thank you for your help! :+1:

Reviewers

De pull request is samengevoegd als 866465c603.

Je kunt ook command line instructies bekijken.

Stap 1:

Vanuit het project, check een branch uit en test de veranderingen.

git checkout -b Media-path master

git pull origin Media-path

Stap 2:

Voeg de wijzigingen samen en update ze op Forgejo.

git checkout master

git merge --no-ff Media-path

git push origin master

Geen beoordelaars

Geen mijlpaal

Niet toegewezen

2 deelnemers

Notificaties

Vervaldatum

De deadline is ongeldig of buiten bereik. Gebruik het formaat 'jjjj-mm-dd'.

Geen vervaldatum ingesteld.

Afhankelijkheden

Geen afhankelijkheden ingesteld.

Laden…

Er is nog geen inhoud.

Labels Mijlpalen

Add environmental variable to control path of media #683

Codecov Report

Reviewers

Stap 1:

Stap 2: