8
16
Derivar 22

Add environmental variable to control path of media #683

Integrado
epsilon-phase integrou 1 cometimento(s) do ramo Media-path no ramo master há 4 anos
epsilon-phase comentou há 4 anos (Migrado de github.com)

This was a request made on the matrix chat that will make it possible to release a snap version, that environmental variable being MEDIA_UPLOAD_DIRECTORY

This was a request made on the matrix chat that will make it possible to release a snap version, that environmental variable being `MEDIA_UPLOAD_DIRECTORY`
codecov[bot] comentou há 4 anos (Migrado de github.com)

Codecov Report

Merging #683 into master will decrease coverage by 0.03%.
The diff coverage is 21.05%.

@@            Coverage Diff            @@
##           master    #683      +/-   ##
=========================================
- Coverage   39.83%   39.8%   -0.04%     
=========================================
  Files          72      72              
  Lines        9368    9383      +15     
  Branches     2219    2219              
=========================================
+ Hits         3732    3735       +3     
- Misses       4580    4592      +12     
  Partials     1056    1056
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/683?src=pr&el=h1) Report > Merging [#683](https://codecov.io/gh/Plume-org/Plume/pull/683?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/dd6d39135e71cd4f4f22befb45da46d89d39ae33?src=pr&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `21.05%`. ```diff @@ Coverage Diff @@ ## master #683 +/- ## ========================================= - Coverage 39.83% 39.8% -0.04% ========================================= Files 72 72 Lines 9368 9383 +15 Branches 2219 2219 ========================================= + Hits 3732 3735 +3 - Misses 4580 4592 +12 Partials 1056 1056 ```
RAOF (Migrado de github.com) reviu há 4 anos
RAOF (Migrado de github.com) deixou um comentário

This looks correct to me; I'm not familiar with Rocket's #[get()] routing stuff, so someone else should check that this is correct.

I'll give it a test! Thanks!

This looks correct to me; I'm not familiar with Rocket's `#[get()]` routing stuff, so someone else should check that this is correct. I'll give it a test! Thanks!
igalic (Migrado de github.com) reviu há 4 anos
igalic (Migrado de github.com) deixou um comentário

👀

👀
igalic (Migrado de github.com) comentou há 4 anos

is this supposed to be deterministic?

is this supposed to be deterministic?
epsilon-phase (Migrado de github.com) reviu há 4 anos
epsilon-phase (Migrado de github.com) comentou há 4 anos

Is it deterministic? It seems to come up with new GUIDs each piece we upload.
(We don't think we quite understand)

Is it deterministic? It seems to come up with new GUIDs each piece we upload. (We don't think we quite understand)
igalic (Migrado de github.com) reviu há 4 anos
igalic (Migrado de github.com) comentou há 4 anos

aah, never mind, i was thinking of something else
(the deterministially random id we use per release for our assets)

aah, never mind, i was thinking of something else (the deterministially random id we use per release for *our* assets)
trinity-1686a reviu há 4 anos
trinity-1686a deixou um comentário
Proprietário(a)

I haven't tested yet, but apart from a minor path mistake, it looks good to me 🙂

I haven't tested yet, but apart from a minor path mistake, it looks good to me :slightly_smiling_face:
Proprietário(a)

the media part is already included in the default value of media_directory (static/media). I don't know if it should be removed from here or from there (it depends on how custom directory should appear), but I think there is one too much

the `media` part is already included in the default value of media_directory (`static/media`). I don't know if it should be removed from here or from there (it depends on how custom directory should appear), but I think there is one too much
epsilon-phase (Migrado de github.com) reviu há 4 anos
epsilon-phase (Migrado de github.com) comentou há 4 anos

Oh, thanks for the catch.

Oh, thanks for the catch.
RAOF comentou há 4 anos (Migrado de github.com)

I've built a snap from this locally, setting the new MEDIA_UPLOAD_DIRECTORY appropriately, and it works!

Once this lands I'll push a PR for the snapcraft metadata and we'll have a fully-functional snap that I can then document! 😁

I've built a snap from this locally, setting the new `MEDIA_UPLOAD_DIRECTORY` appropriately, and it works! Once this lands I'll push a PR for the snapcraft metadata and we'll have a fully-functional snap that I can then document! :grin:
elegaanz (Migrado de github.com) aprovou estas modificações há 4 anos
elegaanz (Migrado de github.com) deixou um comentário

Looks good to me! Thank you for your help! 👍

Looks good to me! Thank you for your help! :+1:

Revisores

A integração foi executada no cometimento 866465c603.

Passo 1:

No seu repositório, crie um novo ramo e teste as modificações.
git checkout -b Media-path master
git pull origin Media-path

Passo 2:

Integre as modificações e envie para o Forgejo.
git checkout master
git merge --no-ff Media-path
git push origin master
Inicie a sessão para participar neste diálogo.
Sem revisores
Sem etapa
Sem encarregados
2 Participantes
Notificações
Data de vencimento
A data de vencimento é inválida ou está fora do intervalo permitido. Por favor, use o formato 'aaaa-mm-dd'.

Sem data de vencimento definida.

Dependências

Não estão definidas dependências.

Referência: Plume/Plume#683
Carregando…
Ainda não há conteúdo.