Add environmental variable to control path of media #683

Birleştirildi

epsilon-phase Media-path içindeki 1 işlemeyi master ile birleştirdi

epsilon-phase yorum yaptı (github.com konumundan göç edildi)

This was a request made on the matrix chat that will make it possible to release a snap version, that environmental variable being MEDIA_UPLOAD_DIRECTORY

This was a request made on the matrix chat that will make it possible to release a snap version, that environmental variable being `MEDIA_UPLOAD_DIRECTORY`

codecov[bot] yorum yaptı (github.com konumundan göç edildi)

Codecov Report

Merging #683 into master will decrease coverage by 0.03%.
The diff coverage is 21.05%.

@@            Coverage Diff            @@
##           master    #683      +/-   ##
=========================================
- Coverage   39.83%   39.8%   -0.04%     
=========================================
  Files          72      72              
  Lines        9368    9383      +15     
  Branches     2219    2219              
=========================================
+ Hits         3732    3735       +3     
- Misses       4580    4592      +12     
  Partials     1056    1056

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/683?src=pr&el=h1) Report > Merging [#683](https://codecov.io/gh/Plume-org/Plume/pull/683?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/dd6d39135e71cd4f4f22befb45da46d89d39ae33?src=pr&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `21.05%`. ```diff @@ Coverage Diff @@ ## master #683 +/- ## ========================================= - Coverage 39.83% 39.8% -0.04% ========================================= Files 72 72 Lines 9368 9383 +15 Branches 2219 2219 ========================================= + Hits 3732 3735 +3 - Misses 4580 4592 +12 Partials 1056 1056 ```

RAOF (github.com konumundan göç edildi) incelendi

RAOF (github.com konumundan göç edildi) bir yorum yaptı

This looks correct to me; I'm not familiar with Rocket's #[get()] routing stuff, so someone else should check that this is correct.

I'll give it a test! Thanks!

This looks correct to me; I'm not familiar with Rocket's `#[get()]` routing stuff, so someone else should check that this is correct. I'll give it a test! Thanks!

igalic (github.com konumundan göç edildi) incelendi

igalic (github.com konumundan göç edildi) bir yorum yaptı

👀

src/routes/medias.rs

igalic (github.com konumundan göç edildi) yorum yaptı

is this supposed to be deterministic?

epsilon-phase (github.com konumundan göç edildi) incelendi

src/routes/medias.rs

epsilon-phase (github.com konumundan göç edildi) yorum yaptı

Is it deterministic? It seems to come up with new GUIDs each piece we upload.
(We don't think we quite understand)

Is it deterministic? It seems to come up with new GUIDs each piece we upload. (We don't think we quite understand)

igalic (github.com konumundan göç edildi) incelendi

src/routes/medias.rs

igalic (github.com konumundan göç edildi) yorum yaptı

aah, never mind, i was thinking of something else
(the deterministially random id we use per release for our assets)

aah, never mind, i was thinking of something else (the deterministially random id we use per release for *our* assets)

trinity-1686a incelendi

trinity-1686a bir yorum yaptı

Sahibi

I haven't tested yet, but apart from a minor path mistake, it looks good to me 🙂

I haven't tested yet, but apart from a minor path mistake, it looks good to me :slightly_smiling_face:

plume-models/src/medias.rs

trinity-1686a yorum yaptı

Sahibi

the media part is already included in the default value of media_directory (static/media). I don't know if it should be removed from here or from there (it depends on how custom directory should appear), but I think there is one too much

the `media` part is already included in the default value of media_directory (`static/media`). I don't know if it should be removed from here or from there (it depends on how custom directory should appear), but I think there is one too much

epsilon-phase (github.com konumundan göç edildi) incelendi

plume-models/src/medias.rs

epsilon-phase (github.com konumundan göç edildi) yorum yaptı

Oh, thanks for the catch.

RAOF yorum yaptı (github.com konumundan göç edildi)

I've built a snap from this locally, setting the new MEDIA_UPLOAD_DIRECTORY appropriately, and it works!

Once this lands I'll push a PR for the snapcraft metadata and we'll have a fully-functional snap that I can then document! 😁

I've built a snap from this locally, setting the new `MEDIA_UPLOAD_DIRECTORY` appropriately, and it works! Once this lands I'll push a PR for the snapcraft metadata and we'll have a fully-functional snap that I can then document! :grin:

🎉 3

elegaanz (github.com konumundan göç edildi) bu değişiklikleri onayladı

elegaanz (github.com konumundan göç edildi) bir yorum yaptı

Looks good to me! Thank you for your help! 👍

Looks good to me! Thank you for your help! :+1:

Gözden Geçirenler

Değişiklik isteği 866465c603 olarak birleştirildi.

komut satırı talimatlarını da görüntüleyebilirsiniz.

1. Adım:

Proje deponuzdan yeni bir dala göz atın ve değişiklikleri test edin.

git checkout -b Media-path master

git pull origin Media-path

2. Adım:

Forgejo'daki değişiklikleri ve güncellemeleri birleştirin.

git checkout master

git merge --no-ff Media-path

git push origin master

Bu konuşmaya katılmak için oturum aç.

Değerlendirici yok

Kilometre Taşı Yok

Atanan Kişi Yok

2 Katılımcı

Bildirimler

Bitiş Tarihi

Bitiş tarihi geçersiz veya aralık dışında. Lütfen 'yyyy-aa-gg' biçimini kullanın.

Bitiş tarihi atanmadı.

Bağımlılıklar

Bağımlılık yok.

Yükleniyor…

Henüz bir içerik yok.

Etiketler Kilometre Taşları

Add environmental variable to control path of media #683

Codecov Report

Gözden Geçirenler

1. Adım:

2. Adım: