Add environmental variable to control path of media #683

Злито

epsilon-phase злито 1 комітів з Media-path до master

epsilon-phase прокоментував(ла) (Перенесено з github.com)

This was a request made on the matrix chat that will make it possible to release a snap version, that environmental variable being MEDIA_UPLOAD_DIRECTORY

This was a request made on the matrix chat that will make it possible to release a snap version, that environmental variable being `MEDIA_UPLOAD_DIRECTORY`

codecov[bot] прокоментував(ла) (Перенесено з github.com)

Codecov Report

Merging #683 into master will decrease coverage by 0.03%.
The diff coverage is 21.05%.

@@            Coverage Diff            @@
##           master    #683      +/-   ##
=========================================
- Coverage   39.83%   39.8%   -0.04%     
=========================================
  Files          72      72              
  Lines        9368    9383      +15     
  Branches     2219    2219              
=========================================
+ Hits         3732    3735       +3     
- Misses       4580    4592      +12     
  Partials     1056    1056

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/683?src=pr&el=h1) Report > Merging [#683](https://codecov.io/gh/Plume-org/Plume/pull/683?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/dd6d39135e71cd4f4f22befb45da46d89d39ae33?src=pr&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `21.05%`. ```diff @@ Coverage Diff @@ ## master #683 +/- ## ========================================= - Coverage 39.83% 39.8% -0.04% ========================================= Files 72 72 Lines 9368 9383 +15 Branches 2219 2219 ========================================= + Hits 3732 3735 +3 - Misses 4580 4592 +12 Partials 1056 1056 ```

RAOF (Перенесено з github.com) рецензовано

RAOF (Перенесено з github.com) додав коментар

This looks correct to me; I'm not familiar with Rocket's #[get()] routing stuff, so someone else should check that this is correct.

I'll give it a test! Thanks!

This looks correct to me; I'm not familiar with Rocket's `#[get()]` routing stuff, so someone else should check that this is correct. I'll give it a test! Thanks!

igalic (Перенесено з github.com) рецензовано

igalic (Перенесено з github.com) додав коментар

👀

src/routes/medias.rs

igalic (Перенесено з github.com) прокоментував(ла)

is this supposed to be deterministic?

epsilon-phase (Перенесено з github.com) рецензовано

src/routes/medias.rs

epsilon-phase (Перенесено з github.com) прокоментував(ла)

Is it deterministic? It seems to come up with new GUIDs each piece we upload.
(We don't think we quite understand)

Is it deterministic? It seems to come up with new GUIDs each piece we upload. (We don't think we quite understand)

igalic (Перенесено з github.com) рецензовано

src/routes/medias.rs

igalic (Перенесено з github.com) прокоментував(ла)

aah, never mind, i was thinking of something else
(the deterministially random id we use per release for our assets)

aah, never mind, i was thinking of something else (the deterministially random id we use per release for *our* assets)

trinity-1686a рецензовано

trinity-1686a додав коментар

Власник

I haven't tested yet, but apart from a minor path mistake, it looks good to me 🙂

I haven't tested yet, but apart from a minor path mistake, it looks good to me :slightly_smiling_face:

plume-models/src/medias.rs

trinity-1686a прокоментував(ла)

Власник

the media part is already included in the default value of media_directory (static/media). I don't know if it should be removed from here or from there (it depends on how custom directory should appear), but I think there is one too much

the `media` part is already included in the default value of media_directory (`static/media`). I don't know if it should be removed from here or from there (it depends on how custom directory should appear), but I think there is one too much

epsilon-phase (Перенесено з github.com) рецензовано

plume-models/src/medias.rs

epsilon-phase (Перенесено з github.com) прокоментував(ла)

Oh, thanks for the catch.

RAOF прокоментував(ла) (Перенесено з github.com)

I've built a snap from this locally, setting the new MEDIA_UPLOAD_DIRECTORY appropriately, and it works!

Once this lands I'll push a PR for the snapcraft metadata and we'll have a fully-functional snap that I can then document! 😁

I've built a snap from this locally, setting the new `MEDIA_UPLOAD_DIRECTORY` appropriately, and it works! Once this lands I'll push a PR for the snapcraft metadata and we'll have a fully-functional snap that I can then document! :grin:

🎉 3

elegaanz (Перенесено з github.com) зміни затверджено

elegaanz (Перенесено з github.com) додав коментар

Looks good to me! Thank you for your help! 👍

Looks good to me! Thank you for your help! :+1:

Рецензенти

Запит на злиття був влитиий як 866465c603.

Також можна переглянути інструкції для командного рядка.

Крок 1:

У репозиторії вашого проєкту перевірте нову гілку і протестуйте зміни.

git checkout -b Media-path master

git pull origin Media-path

Крок 2:

Об'єднати зміни і оновити на Forgejo.

git checkout master

git merge --no-ff Media-path

git push origin master

Підпишіться щоб приєднатися до обговорення.

Немає рецензентів

Етап відсутній

Немає виконавця

2 учасників

Сповіщення

Дата завершення

Термін дії не дійсний або знаходиться за межами допустимого діапазону. Будь ласка використовуйте формат 'yyyy-mm-dd'.

Термін виконання не встановлений.

Залежності

No dependencies set.

Завантаження…

Тут ще немає жодного змісту.

Мітки Етап

Add environmental variable to control path of media #683

Codecov Report

Рецензенти

Крок 1:

Крок 2: