Syntax highlighting
#691
Unito
epsilon-phase
ha unito 12 commit da syntax-highlighting
a master
4 anni fa
Revisori
Richiedi revisione
Nessun revisore
Etichette
Pulisci le etichette
Related to the REST API
Code running on the server
Stuff related to Federation
Related to the front-end
Translations, and related code
More about project management or code than the project itself
The building, or installation process of Plume
Something isn't working
We need to talk
New feature or request
This is a new feature
Compatibility with different browsers, readers and OS
Related to an external package that Plume uses
UI/UX related issues and PRs
Good for newcomers
Extra attention is needed
Issues affecting only mobile UX
How elements're rendered out for the end user
Something else needs to be fixed first
This issue or pull request already exists
This PR is not complete yet
Issues concern a limited number of instances
This doesn't seem right
Need to be discussed by the community (on Loomio)
This PR is ready to be reviewed
Proposed ideas worth considering
This is issue has been created after a vote on Loomio
This will not be worked on
Applica etichette
A: API
Related to the REST API
A: Backend
Code running on the server
A: Federation
Stuff related to Federation
A: Front-End
Related to the front-end
A: I18N
Translations, and related code
A: Meta
More about project management or code than the project itself
A: Security
Build
The building, or installation process of Plume
C: Bug
Something isn't working
C: Discussion
We need to talk
C: Enhancement
New feature or request
C: Feature
This is a new feature
Compatibility
Compatibility with different browsers, readers and OS
Dependency
Related to an external package that Plume uses
Design
UI/UX related issues and PRs
Documentation
Good first issue
Good for newcomers
Help welcome
Extra attention is needed
Mobile
Issues affecting only mobile UX
Rendering
How elements're rendered out for the end user
S: Blocked
Something else needs to be fixed first
S: Duplicate
This issue or pull request already exists
S: Incomplete
This PR is not complete yet
S: Instance specific
Issues concern a limited number of instances
S: Invalid
This doesn't seem right
S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio)
S: Ready for review
This PR is ready to be reviewed
Suggestion
Proposed ideas worth considering
S: Voted on Loomio
This is issue has been created after a vote on Loomio
S: Wontfix
This will not be worked on
Nessuna etichetta
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Traguardo
Imposta traguardo
Milestone pulita
Nessun elemento
Nessuna milestone
Assegnatari
Assegna utenti
Cancella assegnatari
Nessuna assegnatario
2 Partecipanti
Notifiche
Data di scadenza
La data di scadenza non è valida o fuori intervallo. Si prega di utilizzare il formato 'aaaa-mm-dd'.
Nessuna data di scadenza impostata.
Dipendenze
Nessuna dipendenza impostata.
Riferimento: Plume/Plume#691
Fai riferimento in un nuovo problema
Non ci sono ancora contenuti.
Elimina branch 'syntax-highlighting'
L'eliminazione di un branch è definitiva. È un'operazione che NON PUÒ essere annullata. Continuare?
No
Sì
We aren't any good at the css or the styling.
Not to mention that it needs some more work on both the css classes generated accepted, and what needs to be highlighted.
Sublime/textmate syntaxes are rather intricate.
a general comment, if you want GitHub to properly credit you, you may wanna add the email from the commits to your github email addresses.
Works fine overall, just a few remarks:
.punctuation
spans should probably be of the default text color (black/white depending on the theme)-
(for instance,HTML Erlang
would becomehtml-erlang
). It would require you to write your own equivalent offind_syntax_by_name
tho.Here is the list of languages in case someone wants to see it:
Otherwise, it works fine as I said. Thank you!
@ -6,3 +6,3 @@
apt install -y --no-install-recommends git ssh tar gzip ca-certificates default-jre&&\
apt install -y --no-install-recommends binutils-dev build-essential cmake curl gcc gettext git libcurl4-openssl-dev libdw-dev libelf-dev libiberty-dev libpq-dev libsqlite3-dev libssl-dev make openssl pkg-config postgresql postgresql-contrib python zlib1g-dev python3-pip zip unzip &&\
apt install -y --no-install-recommends binutils-dev build-essential cmake curl gcc gettext git libcurl4-openssl-dev libdw-dev libelf-dev libiberty-dev libpq-dev libsqlite3-dev libssl-dev make openssl pkg-config postgresql postgresql-contrib python zlib1g-dev python3-pip zip unzip libclang-dev&&\
rm -rf /var/lib/apt/lists/*
This new dependency should be added to the install docs too.
Still a
TODO
or not?I think this line was for debugging, but it should probably be removed.
Maybe you can chain the two
scan
calls without callinginto_iter
between.@ -34,0 +35,4 @@
"span",
[
"cw-container",
"cw-text",
Are these lines needed? They don't seem to be related to syntax highlighting and were not here before.
We can't think of an easy way to allow that, since it would have to be carrying state between adjacent
Option<Vec<Event>>
sThere could be more variables/highlighting to consider, but we're not much for that, so we'll take it out if you prefer.
@ -34,0 +35,4 @@
"span",
[
"cw-container",
"cw-text",
Those are from the cw'd media stuff, but, since we merged it not quite right, that call was duplicated later on in the builder chain.
not trying to use scan a second time, but
flatten
would look better thanflat_map(into_iter)
Codecov Report
You mean like this?
yes, and even
Can-do :)
As you want.
Works great, thank you!
\o/
Revisori
458baf5f78
.Passo 1:
Dal repository del tuo progetto, fai il check out di un nuovo branch e verifica le modifiche.Passo 2:
Fai il merge delle modifiche e aggiorna su Forgejo.