Snap: store media in the proper directory #695

2019-11-15T16:59:51Z

elegaanz commented

2019-11-15 16:59:51 +00:00

(Migrated from github.com)

Didn't tested it, but it should be ok, if I understand how Snap works.

codecov[bot] commented

2019-11-15 17:21:15 +00:00

(Migrated from github.com)

Codecov Report

Merging #695 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #695   +/-   ##
=======================================
  Coverage   39.25%   39.25%           
=======================================
  Files          72       72           
  Lines        9498     9498           
  Branches     2265     2265           
=======================================
  Hits         3728     3728           
  Misses       4713     4713           
  Partials     1057     1057

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/695?src=pr&el=h1) Report > Merging [#695](https://codecov.io/gh/Plume-org/Plume/pull/695?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/c484ca6afe29a2d6c062b99df22485fcbc57cb9b?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #695 +/- ## ======================================= Coverage 39.25% 39.25% ======================================= Files 72 72 Lines 9498 9498 Branches 2265 2265 ======================================= Hits 3728 3728 Misses 4713 4713 Partials 1057 1057 ```

RAOF commented

2019-11-16 04:22:00 +00:00

(Migrated from github.com)

Oh, damn. I didn't push this yet!

RAOF (Migrated from github.com) requested changes 2019-11-16 04:34:50 +00:00

RAOF (Migrated from github.com) left a comment

Needs at least mdkir -> mkdir fixed, but we probably want #698 instead?

Needs at least `mdkir` -> `mkdir` fixed, but we probably want #698 instead?

snap/hooks/configure

					
				@ -45,4 +45,6 @@ then

				    touch ${SNAP_COMMON}/initial-migrations-run

				fi

				mdkir "${SNAP_DATA}/media"

RAOF (Migrated from github.com) commented

2019-11-16 04:33:48 +00:00

The configure hook gets run each time the snap is upgraded; the name might be a bit misleading. This would fail the first time the snap is upgraded, as mkdir will fail to create an existing directory.

It's also slightly misspelled 😉

The `configure` hook gets run each time the snap is upgraded; the name might be a bit misleading. This would fail the first time the snap is upgraded, as `mkdir` will fail to create an existing directory. It's also *slightly* misspelled :wink:

elegaanz commented

2019-11-16 10:06:45 +00:00

(Migrated from github.com)

Closing in favor of #698

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

RAOF

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#695

Rows
Columns