Fix #637 : Markdown footnotes #700

Fusionado

papey fusionados 2 commits de fix-markdown-notes en master

papey comentado (Migrado desde github.com)

Here is fix for issue #637 that :

Ensure footnotes classes are not filtered by html sanitizer
Add some footnote style rules

An example of footnotes using this fix :

Markdown :

Here is something[^a]


Here is another thing[^b]

[^a]: something

[^b]: another thing

Note that there is some cpull-markdown related syntax : a carriage return is needed between each note definition

Here is fix for issue #637 that : - Ensure footnotes classes are not filtered by html sanitizer - Add some footnote style rules An example of footnotes using this fix : **Markdown :** ```md Here is something[^a] Here is another thing[^b] [^a]: something [^b]: another thing ``` ![Footnotes rendeering](https://user-images.githubusercontent.com/17273325/69247036-0d144700-0baa-11ea-83bd-bbd9fa6564c4.png) Note that there is some cpull-markdown related syntax : **a carriage return is needed between each note definition**

❤️ 1

papey comentado (Migrado desde github.com)

Note that back reference are not supported (yet) by cpull-markdown : https://github.com/raphlinus/pulldown-cmark/issues/142

codecov[bot] comentado (Migrado desde github.com)

Codecov Report

Merging #700 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #700   +/-   ##
=======================================
  Coverage   39.25%   39.25%           
=======================================
  Files          72       72           
  Lines        9498     9498           
  Branches     2265     2265           
=======================================
  Hits         3728     3728           
  Misses       4713     4713           
  Partials     1057     1057

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/700?src=pr&el=h1) Report > Merging [#700](https://codecov.io/gh/Plume-org/Plume/pull/700?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/7f296b2ef2fe17482f24fe84b4ecb3ae0947601f?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #700 +/- ## ======================================= Coverage 39.25% 39.25% ======================================= Files 72 72 Lines 9498 9498 Branches 2265 2265 ======================================= Hits 3728 3728 Misses 4713 4713 Partials 1057 1057 ```

elegaanz (Migrado desde github.com) aprobado estos cambios

elegaanz (Migrado desde github.com) dejó un comentario

Thanks!

Revisores

El Pull Request se ha fusionado como 3bd2305115.

También puede ver instrucciones de línea de comandos.

Paso 1:

Desde el repositorio de su proyecto, revisa una nueva rama y prueba los cambios.

git checkout -b fix-markdown-notes master

git pull origin fix-markdown-notes

Paso 2:

Combine los cambios y actualice en Forgejo.

git checkout master

git merge --no-ff fix-markdown-notes

git push origin master

Inicie sesión para unirse a esta conversación.

No hay revisores

Sin Milestone

No asignados

1 participantes

Notificaciones

Fecha de vencimiento

La fecha de vencimiento es inválida o está fuera de rango. Por favor utilice el formato 'aaaa-mm-dd'.

Sin fecha de vencimiento.

Dependencias

No se han establecido dependencias.

Cargando…

Aún no existe contenido.

Etiquetas Hitos

Fix #637 : Markdown footnotes #700

Codecov Report

Revisores

Paso 1:

Paso 2: