Fix #637 : Markdown footnotes #700

Merge aplicado

papey aplicou merge dos 2 commits de fix-markdown-notes em master

papey comentou (Migrado de github.com)

Here is fix for issue #637 that :

Ensure footnotes classes are not filtered by html sanitizer
Add some footnote style rules

An example of footnotes using this fix :

Markdown :

Here is something[^a]


Here is another thing[^b]

[^a]: something

[^b]: another thing

Note that there is some cpull-markdown related syntax : a carriage return is needed between each note definition

Here is fix for issue #637 that : - Ensure footnotes classes are not filtered by html sanitizer - Add some footnote style rules An example of footnotes using this fix : **Markdown :** ```md Here is something[^a] Here is another thing[^b] [^a]: something [^b]: another thing ``` ![Footnotes rendeering](https://user-images.githubusercontent.com/17273325/69247036-0d144700-0baa-11ea-83bd-bbd9fa6564c4.png) Note that there is some cpull-markdown related syntax : **a carriage return is needed between each note definition**

❤️ 1

papey comentou (Migrado de github.com)

Note that back reference are not supported (yet) by cpull-markdown : https://github.com/raphlinus/pulldown-cmark/issues/142

codecov[bot] comentou (Migrado de github.com)

Codecov Report

Merging #700 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #700   +/-   ##
=======================================
  Coverage   39.25%   39.25%           
=======================================
  Files          72       72           
  Lines        9498     9498           
  Branches     2265     2265           
=======================================
  Hits         3728     3728           
  Misses       4713     4713           
  Partials     1057     1057

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/700?src=pr&el=h1) Report > Merging [#700](https://codecov.io/gh/Plume-org/Plume/pull/700?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/7f296b2ef2fe17482f24fe84b4ecb3ae0947601f?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #700 +/- ## ======================================= Coverage 39.25% 39.25% ======================================= Files 72 72 Lines 9498 9498 Branches 2265 2265 ======================================= Hits 3728 3728 Misses 4713 4713 Partials 1057 1057 ```

elegaanz (Migrado de github.com) aprovou estas alterações

elegaanz (Migrado de github.com) deixou um comentário

Thanks!

Revisores

O pull request teve merge aplicado como 3bd2305115.

Você também pode ver as instruções para a linha de comandos.

Passo 1:

No repositório do seu projeto, crie um novo branch e teste as alterações.

git checkout -b fix-markdown-notes master

git pull origin fix-markdown-notes

Passo 2:

Faça merge das alterações e atualize no Forgejo.

git checkout master

git merge --no-ff fix-markdown-notes

git push origin master

Acesse para participar desta conversação.

Sem revisor

Sem marco

Sem responsável

1 participante(s)

Notificações

Data limite

A data limite é inválida ou está fora do intervalo. Por favor, use o formato 'dd/mm/aaaa'.

Data limite não informada.

Dependências

Nenhuma dependência definida.

Carregando…

Ainda não há conteúdo.

Etiquetas Marcos

Fix #637 : Markdown footnotes #700

Codecov Report

Revisores

Passo 1:

Passo 2: