Email blocklisting
#718
Sammanfogat
epsilon-phase
sammanfogade 9 incheckningar från email-blocklisting
in i master
4 år sedan
Granskare
Begär granskning
Inga granskare
Etiketter
Rensa etiketter
Related to the REST API
Code running on the server
Stuff related to Federation
Related to the front-end
Translations, and related code
More about project management or code than the project itself
The building, or installation process of Plume
Something isn't working
We need to talk
New feature or request
This is a new feature
Compatibility with different browsers, readers and OS
Related to an external package that Plume uses
UI/UX related issues and PRs
Good for newcomers
Extra attention is needed
Issues affecting only mobile UX
How elements're rendered out for the end user
Something else needs to be fixed first
This issue or pull request already exists
This PR is not complete yet
Issues concern a limited number of instances
This doesn't seem right
Need to be discussed by the community (on Loomio)
This PR is ready to be reviewed
Proposed ideas worth considering
This is issue has been created after a vote on Loomio
This will not be worked on
Tillämpa etiketter
A: API
Related to the REST API
A: Backend
Code running on the server
A: Federation
Stuff related to Federation
A: Front-End
Related to the front-end
A: I18N
Translations, and related code
A: Meta
More about project management or code than the project itself
A: Security
Build
The building, or installation process of Plume
C: Bug
Something isn't working
C: Discussion
We need to talk
C: Enhancement
New feature or request
C: Feature
This is a new feature
Compatibility
Compatibility with different browsers, readers and OS
Dependency
Related to an external package that Plume uses
Design
UI/UX related issues and PRs
Documentation
Good first issue
Good for newcomers
Help welcome
Extra attention is needed
Mobile
Issues affecting only mobile UX
Rendering
How elements're rendered out for the end user
S: Blocked
Something else needs to be fixed first
S: Duplicate
This issue or pull request already exists
S: Incomplete
This PR is not complete yet
S: Instance specific
Issues concern a limited number of instances
S: Invalid
This doesn't seem right
S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio)
S: Ready for review
This PR is ready to be reviewed
Suggestion
Proposed ideas worth considering
S: Voted on Loomio
This is issue has been created after a vote on Loomio
S: Wontfix
This will not be worked on
Ingen Etikett
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milsten
Ange milstolpe
Rensa milstenar
Inga objekt
Ingen Milsten
Tilldelade
Tilldela användare
Rensa tilldelade
Ingen tilldelad
1 Deltagare
Notiser
Förfallodatum
Förfallodatumet är ogiltigt eller utanför gränserna. Använd formatet 'åååå-mm-dd'.
Inget förfallodatum satt.
Beroenden
No dependencies set.
Reference: Plume/Plume#718
Referens i nytt ärende
Det finns inget innehåll än.
Ta bort branch 'email-blocklisting'
Borttagning utav en branch är permanent. Detta KAN INTE ångras. Vill du fortsätta?
Nej
Ja
This should address #587 and any concerns for the terminology hopefully.
Codecov Report
very very tired 👀
I'm a bit confused as to why there are no spaces after
,
s in function calls, starting hereOh, that's because rustfmt can't touch the templates :)
Fixed.
Globally it works fine, great job! I left comments about "details", but after that it should be good!
Maybe make this column unique, to avoid duplicated blocks?
Little detail, so if you don't feel like doing it, don't change, but: keywords in SQL usually are in all caps.
You could use https://doc.rust-lang.org/std/result/enum.Result.html#method.err
Maybe add a
@
so that in only matches one domain, and not all domains with the same ending (I doubt this case will ever be encountered actually, be just to be sure).It should probably redirect to
/admin/emails
instead.It should probably redirect to
/admin/emails
.Maybe call it
/admin/emails/delete
if it is what it does?@ -177,0 +205,4 @@
}
#[post("/admin/emails/new", data = "<form>")]
pub fn add_email_blocklist(
I'm almost sure I did something similar for user management, couldn't the code be shared between the two?
@ -14,6 +14,7 @@
(&uri!(instance::admin).to_string(), i18n!(ctx.1, "Configuration"), true),
(&uri!(instance::admin_instances: page = _).to_string(), i18n!(ctx.1, "Instances"), false),
(&uri!(instance::admin_users: page = _).to_string(), i18n!(ctx.1, "Users"), false),
(&uri!(instance::admin_email_blocklist: page=_).to_string(), i18n!(ctx.1, "Email blocklist"), false)
This link is absent from the "Instances" page.
This button should probably be red (
class="destructive"
IIRC), and explicitly say that it deletes all blocklisted emails if it is what it does.This
<input>
should be before the label IMO, as it is usually done with checkboxes.@ -0,0 +6,4 @@
@(ctx:BaseContext, emails: Vec<BlocklistedEmail>, page:i32, n_pages:i32)
@:base(ctx, i18n!(ctx.1, "Blocklisted Emails"), {}, {}, {
<h1>@i18n!(ctx.1,"Blocklisted Emails")</h1>
@tabs(&[
There should probably be a
<h1>
here, like on other administration pages.It deletes only the ones selected.
But yeah, that's a good idea
@ -177,0 +205,4 @@
}
#[post("/admin/emails/new", data = "<form>")]
pub fn add_email_blocklist(
We couldn't see how to do that cleanly, since that's significantly more complicated.
That makes sense.
Might as well follow the conventions :)
That's much nicer :)
@ -177,0 +205,4 @@
}
#[post("/admin/emails/new", data = "<form>")]
pub fn add_email_blocklist(
OK, let's do it this way then, we can always refactor later if needed.
Sorry, actually there is more… 😕 (but it should be the last this time!)
Actually, this button should probably be hidden if there is currently no blocked addresses, and a placeholder message should be shown (
<p class="center">
is made for that).Moving it inside of the
<label>
tag would be better, otherwise they are not on the same line, and it is hard to understand they are linked.There is a
i
missing ini18n
here, it doesn't show correctly (it shouldn't even compile, but for some reason, it does).What an odd mystery
That makes sense
Perfect! Thank you!
Granskare
f3c05dae62
.Step 1:
From your project repository, check out a new branch and test the changes.Step 2:
Merge the changes and update on Forgejo.