Fix #699 #719

Merged
epsilon-phase merged 1 commits from hashtag-fix into master 4 years ago
epsilon-phase commented 4 years ago (Migrated from github.com)

We did need to adjust the testcases as the many spaces ones are, as it turns out, also parsed as code blocks.

But that seems like a behavior of markdown we shouldn't seek to adjust without intention

We did need to adjust the testcases as the many spaces ones are, as it turns out, also parsed as code blocks. But that seems like a behavior of markdown we shouldn't seek to adjust without intention
codecov[bot] commented 4 years ago (Migrated from github.com)

Codecov Report

Merging #719 into master will increase coverage by 0.01%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##           master     #719      +/-   ##
==========================================
+ Coverage    39.3%   39.32%   +0.01%     
==========================================
  Files          72       72              
  Lines        9534     9542       +8     
  Branches     2275     2277       +2     
==========================================
+ Hits         3747     3752       +5     
  Misses       4714     4714              
- Partials     1073     1076       +3
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/719?src=pr&el=h1) Report > Merging [#719](https://codecov.io/gh/Plume-org/Plume/pull/719?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/458baf5f78daec1b823e0bbd17eaa96c23ae92f8?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `86.66%`. ```diff @@ Coverage Diff @@ ## master #719 +/- ## ========================================== + Coverage 39.3% 39.32% +0.01% ========================================== Files 72 72 Lines 9534 9542 +8 Branches 2275 2277 +2 ========================================== + Hits 3747 3752 +5 Misses 4714 4714 - Partials 1073 1076 +3 ```
elegaanz (Migrated from github.com) approved these changes 4 years ago
elegaanz (Migrated from github.com) left a comment

Great! Thank you!

Great! Thank you!
kiwii referenced this issue from a commit 4 years ago

Reviewers

The pull request has been merged as e6bdeb7c4b.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b hashtag-fix master
git pull origin hashtag-fix

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff hashtag-fix
git push origin master
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#719
Loading…
There is no content yet.