Fix RSS issues #720

Yhdistetty

papey yhdistetty 2 committia lähteestä fix/#673-date-id-rss kohteeseen master

papey kommentoi (Migrated from github.com)

Here is a PR relative to issue #673.

At this state, the PR adds id and published field for each blog entry inside the RSS feed.

I'm not sure but it's look like there is no method or field attached to post struct to get information about update metadata.

I can add this but I want to be sure that it's in the scope of this PR.

Thanks for you're reply.

Here is a PR relative to issue #673. At this state, the PR adds `id` and `published` field for each blog entry inside the RSS feed. I'm not sure but it's look like there is no method or field attached to `post` struct to get information about update metadata. I can add this but I want to be sure that it's in the scope of this PR. Thanks for you're reply.

👍 2

codecov[bot] kommentoi (Migrated from github.com)

Codecov Report

Merging #720 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #720      +/-   ##
==========================================
- Coverage    39.3%   39.29%   -0.01%     
==========================================
  Files          72       72              
  Lines        9534     9536       +2     
  Branches     2275     2275              
==========================================
  Hits         3747     3747              
- Misses       4714     4716       +2     
  Partials     1073     1073

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/720?src=pr&el=h1) Report > Merging [#720](https://codecov.io/gh/Plume-org/Plume/pull/720?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/458baf5f78daec1b823e0bbd17eaa96c23ae92f8?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #720 +/- ## ========================================== - Coverage 39.3% 39.29% -0.01% ========================================== Files 72 72 Lines 9534 9536 +2 Branches 2275 2275 ========================================== Hits 3747 3747 - Misses 4714 4716 +2 Partials 1073 1073 ```

epsilon-phase kommentoi (Migrated from github.com)

Our personal feeling is that you are correct in that adding an updated field is outside of the scope of the pull request.

We'll review this after dinner, thanks for contributing :)

Our personal feeling is that you are correct in that adding an updated field is outside of the scope of the pull request. We'll review this after dinner, thanks for contributing :)

epsilon-phase (Migrated from github.com) hyväksyi nämä muutokset

papey kommentoi (Migrated from github.com)

Here is the issue related to update field for blog entries https://github.com/Plume-org/Plume/issues/722

👍 1

kiwii viittasi tähän ongelmaan commitissa

WIP: Fix RSS issues (#720) * Add id field to RSS feed * Add published field to RSS feed

Reviewers

The pull request has been merged as 23049b638c.

You can also view command line instructions.

Vaihe 1:

From your project repository, check out a new branch and test the changes.

git checkout -b fix/#673-date-id-rss master

git pull origin fix/#673-date-id-rss

Vaihe 2:

Merge the changes and update on Forgejo.

git checkout master

git merge --no-ff fix/#673-date-id-rss

git push origin master

No reviewers

Ei merkkipaalua

Ei käsittelijää

1 osallistujaa

Ilmoitukset

Määräpäivä

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

Määräpäivää ei asetettu.

Riippuvuudet

Riippuvuuksia ei asetettu.

Ladataan…

Sisältöä ei vielä ole.

Tunnisteet Merkkipaalut

Fix RSS issues #720

Codecov Report

Reviewers

Vaihe 1:

Vaihe 2: