Add warning for missing documentation
#727
Cerrada
elegaanz desea fusionar 3 commits de missing-docs
en master
recuperar de: missing-docs
fusionar en: Plume:master
Plume:paginate-search-init
Plume:main
Plume:s3
Plume:fix-delete-user
Plume:timeline-cli
Plume:blog-title
Plume:signature
Plume:remove-dup-images
Plume:ldap-non-anon
Plume:drone-ci
Plume:DearRude/force-lang
Plume:igalic/go/async-all-mut
Plume:go/async
Plume:floreal/translations-update
Plume:RAOF/fix-arm64-build
Plume:epsilon-phase/authorized-fetch
Plume:upgrade
Plume:improve-the-editor-once-again
Plume:igalic/feat/custom-fairing-domains
Plume:feature/ldap
Plume:test/dotenv_error
Plume:fix-mobile-margin
Revisores
Solicitar revisión
No hay revisores
Etiquetas
Limpiar etiquetas
Related to the REST API
Code running on the server
Stuff related to Federation
Related to the front-end
Translations, and related code
More about project management or code than the project itself
The building, or installation process of Plume
Something isn't working
We need to talk
New feature or request
This is a new feature
Compatibility with different browsers, readers and OS
Related to an external package that Plume uses
UI/UX related issues and PRs
Good for newcomers
Extra attention is needed
Issues affecting only mobile UX
How elements're rendered out for the end user
Something else needs to be fixed first
This issue or pull request already exists
This PR is not complete yet
Issues concern a limited number of instances
This doesn't seem right
Need to be discussed by the community (on Loomio)
This PR is ready to be reviewed
Proposed ideas worth considering
This is issue has been created after a vote on Loomio
This will not be worked on
Aplicar etiquetas
A: API
Related to the REST API
A: Backend
Code running on the server
A: Federation
Stuff related to Federation
A: Front-End
Related to the front-end
A: I18N
Translations, and related code
A: Meta
More about project management or code than the project itself
A: Security
Build
The building, or installation process of Plume
C: Bug
Something isn't working
C: Discussion
We need to talk
C: Enhancement
New feature or request
C: Feature
This is a new feature
Compatibility
Compatibility with different browsers, readers and OS
Dependency
Related to an external package that Plume uses
Design
UI/UX related issues and PRs
Documentation
Good first issue
Good for newcomers
Help welcome
Extra attention is needed
Mobile
Issues affecting only mobile UX
Rendering
How elements're rendered out for the end user
S: Blocked
Something else needs to be fixed first
S: Duplicate
This issue or pull request already exists
S: Incomplete
This PR is not complete yet
S: Instance specific
Issues concern a limited number of instances
S: Invalid
This doesn't seem right
S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio)
S: Ready for review
This PR is ready to be reviewed
Suggestion
Proposed ideas worth considering
S: Voted on Loomio
This is issue has been created after a vote on Loomio
S: Wontfix
This will not be worked on
Sin etiquetas
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Fijar hito
Limpiar Milestone
No hay elementos
Sin Milestone
Asignados
Asignar usuarios
Limpiar asignados
No asignados
2 participantes
Notificaciones
Fecha de vencimiento
La fecha de vencimiento es inválida o está fuera de rango. Por favor utilice el formato 'aaaa-mm-dd'.
Sin fecha de vencimiento.
Dependencias
No se han establecido dependencias.
Referencia: Plume/Plume#727
Referencia en una nueva incidencia
Aún no existe contenido.
Eliminar la rama con el nombre 'missing-docs'
Eliminar una rama es permanente. NO PUEDE deshacerse. ¿Continuar?
No
Sí
To force us to document our code.
I didn't added it to binaries (
src/
andplume-cli/
because it didn't really made sense for them IMO), but I can.Also, to keep this PR small, I propose that we slowly document each function as we modify them in other PRs. Does it seem reasonable to you?
The overall idea sounds reasonable. Considering
src/
(maybeplume-cli
) also contains some non trivial code (remember url! in the custom domain PR?), I think doing it would make sense to apply that on them tooYou should add a feature to all crates, and replace current attribute with
#![cfg_attr(not(feature = "ci"), warn(missing_docs))]
(which would be set in CI). That way it won't fail on the deny(warnings) on clippycan't we add that that somewhere to
clippy
orcheck
?Isn't there a better way to allow just these warnings in clippy?
Codecov Report
Paso 1:
Desde el repositorio de su proyecto, revisa una nueva rama y prueba los cambios.Paso 2:
Combine los cambios y actualice en Forgejo.