Fixed: #713: Disply likes and boosts on post cards #744

Fusionado
floreal fusionados 1 commits de display-boost-and-likes-in-timelines en master hace 4 años
floreal comentado hace 4 años (Migrado desde github.com)

This is a basic and simple way to display them. No interaction possible.

Alos, this patch is not optimised. as everytime a partial post_card is
called, Post::count_likes() and Post::count_reshares() are called
which means quite a few more quesies are sent to database unless diesel
uses some cache mechanisem.

A way to enhance this this would be to keep a count of likes and reshares
are kept in Post model / table.

This is a basic and simple way to display them. No interaction possible. Alos, this patch is not optimised. as everytime a partial post_card is called, `Post::count_likes()` and `Post::count_reshares()` are called which means quite a few more quesies are sent to database unless diesel uses some cache mechanisem. A way to enhance this this would be to keep a count of likes and reshares are kept in Post model / table.
floreal comentado hace 4 años (Migrado desde github.com)

On dark theme:
image
On Light theme:
image

On dark theme: ![image](https://user-images.githubusercontent.com/386442/79052773-12495f80-7c39-11ea-8930-5cb96be67065.png) On Light theme: ![image](https://user-images.githubusercontent.com/386442/79052899-cc40cb80-7c39-11ea-8e80-95a7fe73eee5.png)
elegaanz comentado hace 4 años (Migrado desde github.com)

Thanks for the PR.

I'm not 100% about the presentation, these counters looks too big and in the middle of the card to me, like if they were the most important information here. Maybe moving on the same line as the author/blog/date would help?

And for the like/share counter cache on Post, feel free to implement it if you want, but this PR can probably be merged as it is. I don't know if Diesel does caching, but Postgres and SQlite certainly do, so it should be fine.

Thanks for the PR. I'm not 100% about the presentation, these counters looks too big and in the middle of the card to me, like if they were the most important information here. Maybe moving on the same line as the author/blog/date would help? And for the like/share counter cache on Post, feel free to implement it if you want, but this PR can probably be merged as it is. I don't know if Diesel does caching, but Postgres and SQlite certainly do, so it should be fine.
floreal comentado hace 4 años (Migrado desde github.com)

Ok, how about that?

image

image

On larger cards:
image

@elegaanz is it ok with you ?

Ok, how about that? ![image](https://user-images.githubusercontent.com/386442/79077054-ae896a00-7cfe-11ea-85cc-9aa6e3a5a774.png) ![image](https://user-images.githubusercontent.com/386442/79077076-dc6eae80-7cfe-11ea-989d-9ea6eae52ba9.png) On larger cards: ![image](https://user-images.githubusercontent.com/386442/79077080-edb7bb00-7cfe-11ea-92b3-6179ad230a4f.png) @elegaanz is it ok with you ?
elegaanz (Migrado desde github.com) aprobado estos cambios hace 4 años
elegaanz (Migrado desde github.com) dejó un comentario

Yes, it looks great! Thank you

Yes, it looks great! Thank you

Revisores

El Pull Request se ha fusionado como 4e43c676b4.

Paso 1:

Desde el repositorio de su proyecto, revisa una nueva rama y prueba los cambios.
git checkout -b display-boost-and-likes-in-timelines master
git pull origin display-boost-and-likes-in-timelines

Paso 2:

Combine los cambios y actualice en Forgejo.
git checkout master
git merge --no-ff display-boost-and-likes-in-timelines
git push origin master
Inicie sesión para unirse a esta conversación.
No hay revisores
Sin Milestone
No asignados
1 participantes
Notificaciones
Fecha de vencimiento
La fecha de vencimiento es inválida o está fuera de rango. Por favor utilice el formato 'aaaa-mm-dd'.

Sin fecha de vencimiento.

Dependencias

No se han establecido dependencias.

Referencia: Plume/Plume#744
Cargando…
Aún no existe contenido.