Fixed: #713: Disply likes and boosts on post cards #744

Samengevoegd

floreal heeft 1 commit van display-boost-and-likes-in-timelines samengevoegd in master

2020-04-12 19:29:49 +00:00

floreal reageerde

2020-04-11 18:32:56 +00:00

(Gemigreerd van github.com)

This is a basic and simple way to display them. No interaction possible.

Alos, this patch is not optimised. as everytime a partial post_card is
called, Post::count_likes() and Post::count_reshares() are called
which means quite a few more quesies are sent to database unless diesel
uses some cache mechanisem.

A way to enhance this this would be to keep a count of likes and reshares
are kept in Post model / table.

This is a basic and simple way to display them. No interaction possible. Alos, this patch is not optimised. as everytime a partial post_card is called, `Post::count_likes()` and `Post::count_reshares()` are called which means quite a few more quesies are sent to database unless diesel uses some cache mechanisem. A way to enhance this this would be to keep a count of likes and reshares are kept in Post model / table.

floreal reageerde

2020-04-11 19:17:10 +00:00

(Gemigreerd van github.com)

On dark theme:

On Light theme:

On dark theme: ![image](https://user-images.githubusercontent.com/386442/79052773-12495f80-7c39-11ea-8930-5cb96be67065.png) On Light theme: ![image](https://user-images.githubusercontent.com/386442/79052899-cc40cb80-7c39-11ea-8e80-95a7fe73eee5.png)

elegaanz reageerde

2020-04-12 15:39:35 +00:00

(Gemigreerd van github.com)

Thanks for the PR.

I'm not 100% about the presentation, these counters looks too big and in the middle of the card to me, like if they were the most important information here. Maybe moving on the same line as the author/blog/date would help?

And for the like/share counter cache on Post, feel free to implement it if you want, but this PR can probably be merged as it is. I don't know if Diesel does caching, but Postgres and SQlite certainly do, so it should be fine.

Thanks for the PR. I'm not 100% about the presentation, these counters looks too big and in the middle of the card to me, like if they were the most important information here. Maybe moving on the same line as the author/blog/date would help? And for the like/share counter cache on Post, feel free to implement it if you want, but this PR can probably be merged as it is. I don't know if Diesel does caching, but Postgres and SQlite certainly do, so it should be fine.

floreal reageerde

2020-04-12 18:48:17 +00:00

(Gemigreerd van github.com)

Ok, how about that?

On larger cards:

@elegaanz is it ok with you ?

Ok, how about that? ![image](https://user-images.githubusercontent.com/386442/79077054-ae896a00-7cfe-11ea-85cc-9aa6e3a5a774.png) ![image](https://user-images.githubusercontent.com/386442/79077076-dc6eae80-7cfe-11ea-989d-9ea6eae52ba9.png) On larger cards: ![image](https://user-images.githubusercontent.com/386442/79077080-edb7bb00-7cfe-11ea-92b3-6179ad230a4f.png) @elegaanz is it ok with you ?

elegaanz (Gemigreerd van github.com) heeft deze veranderingen 2020-04-12 19:29:04 +00:00 goedgekeurd