Fixed: #713: Disply likes and boosts on post cards
#744
Integrado
floreal
integrou 1 cometimento(s) do ramo display-boost-and-likes-in-timelines
no ramo master
há 4 anos
Carregando…
Criar uma nova questão referindo esta
Ainda não há conteúdo.
Eliminar o ramo 'display-boost-and-likes-in-timelines'
Eliminar um ramo é algo permanente. NÃO PODERÁ ser revertido. Quer continuar?
This is a basic and simple way to display them. No interaction possible.
Alos, this patch is not optimised. as everytime a partial post_card is
called,
Post::count_likes()
andPost::count_reshares()
are calledwhich means quite a few more quesies are sent to database unless diesel
uses some cache mechanisem.
A way to enhance this this would be to keep a count of likes and reshares
are kept in Post model / table.
On dark theme:
On Light theme:
Thanks for the PR.
I'm not 100% about the presentation, these counters looks too big and in the middle of the card to me, like if they were the most important information here. Maybe moving on the same line as the author/blog/date would help?
And for the like/share counter cache on Post, feel free to implement it if you want, but this PR can probably be merged as it is. I don't know if Diesel does caching, but Postgres and SQlite certainly do, so it should be fine.
Ok, how about that?
On larger cards:
@elegaanz is it ok with you ?
Yes, it looks great! Thank you
Revisores
4e43c676b4
.Passo 1:
No seu repositório, crie um novo ramo e teste as modificações.Passo 2:
Integre as modificações e envie para o Forgejo.