Fixed: #713: Disply likes and boosts on post cards #744

Злито

floreal злито 1 комітів з display-boost-and-likes-in-timelines до master

floreal прокоментував(ла) (Перенесено з github.com)

This is a basic and simple way to display them. No interaction possible.

Alos, this patch is not optimised. as everytime a partial post_card is
called, Post::count_likes() and Post::count_reshares() are called
which means quite a few more quesies are sent to database unless diesel
uses some cache mechanisem.

A way to enhance this this would be to keep a count of likes and reshares
are kept in Post model / table.

This is a basic and simple way to display them. No interaction possible. Alos, this patch is not optimised. as everytime a partial post_card is called, `Post::count_likes()` and `Post::count_reshares()` are called which means quite a few more quesies are sent to database unless diesel uses some cache mechanisem. A way to enhance this this would be to keep a count of likes and reshares are kept in Post model / table.

floreal прокоментував(ла) (Перенесено з github.com)

On dark theme:

On Light theme:

On dark theme: ![image](https://user-images.githubusercontent.com/386442/79052773-12495f80-7c39-11ea-8930-5cb96be67065.png) On Light theme: ![image](https://user-images.githubusercontent.com/386442/79052899-cc40cb80-7c39-11ea-8e80-95a7fe73eee5.png)

elegaanz прокоментував(ла) (Перенесено з github.com)

Thanks for the PR.

I'm not 100% about the presentation, these counters looks too big and in the middle of the card to me, like if they were the most important information here. Maybe moving on the same line as the author/blog/date would help?

And for the like/share counter cache on Post, feel free to implement it if you want, but this PR can probably be merged as it is. I don't know if Diesel does caching, but Postgres and SQlite certainly do, so it should be fine.

Thanks for the PR. I'm not 100% about the presentation, these counters looks too big and in the middle of the card to me, like if they were the most important information here. Maybe moving on the same line as the author/blog/date would help? And for the like/share counter cache on Post, feel free to implement it if you want, but this PR can probably be merged as it is. I don't know if Diesel does caching, but Postgres and SQlite certainly do, so it should be fine.

floreal прокоментував(ла) (Перенесено з github.com)

Ok, how about that?

On larger cards:

@elegaanz is it ok with you ?

Ok, how about that? ![image](https://user-images.githubusercontent.com/386442/79077054-ae896a00-7cfe-11ea-85cc-9aa6e3a5a774.png) ![image](https://user-images.githubusercontent.com/386442/79077076-dc6eae80-7cfe-11ea-989d-9ea6eae52ba9.png) On larger cards: ![image](https://user-images.githubusercontent.com/386442/79077080-edb7bb00-7cfe-11ea-92b3-6179ad230a4f.png) @elegaanz is it ok with you ?

elegaanz (Перенесено з github.com) зміни затверджено

elegaanz (Перенесено з github.com) додав коментар

Yes, it looks great! Thank you

kiwii згадано цю задачу в коміті

Fixed: #713: Disply likes and boosts on post cards (#744) This is a basic and simple way to display them. No interaction possible. Alos, this patch is not optimised. as everytime a partial post_card is called, `Post::count_likes()` and `Post::count_reshares()` are called which means quite a few more quesies are sent to database unless diesel uses some cache mechanisem. A way to enhance this this would be to keep a count of likes and reshares are kept in Post model / table.

Рецензенти

Запит на злиття був влитиий як 4e43c676b4.

Також можна переглянути інструкції для командного рядка.

Крок 1:

У репозиторії вашого проєкту перевірте нову гілку і протестуйте зміни.

git checkout -b display-boost-and-likes-in-timelines master

git pull origin display-boost-and-likes-in-timelines

Крок 2:

Об'єднати зміни і оновити на Forgejo.

git checkout master

git merge --no-ff display-boost-and-likes-in-timelines

git push origin master

Підпишіться щоб приєднатися до обговорення.

Немає рецензентів

Етап відсутній

Немає виконавця

1 учасників

Сповіщення

Дата завершення

Термін дії не дійсний або знаходиться за межами допустимого діапазону. Будь ласка використовуйте формат 'yyyy-mm-dd'.

Термін виконання не встановлений.

Залежності

No dependencies set.

Завантаження…

Тут ще немає жодного змісту.

Мітки Етап

Fixed: #713: Disply likes and boosts on post cards #744

Рецензенти

Крок 1:

Крок 2: