Move stylesheets for header from _global.sccss to _header.scss #749

Merged

KitaitiMakoto merged 1 commits from menu-icon into master

KitaitiMakoto commented (Migrated from github.com)

Hi,

I found menu icon is not present when I use small screen device(smart phone):

And wrote patch to fix it:

Could you consider to merge it?

Hi, I found menu icon is not present when I use small screen device(smart phone): ![](https://i.gyazo.com/da502fbee6a0f2d0b32b42667f8afc05.gif) And wrote patch to fix it: ![](https://i.gyazo.com/79a2d6c668b27ccd9e56cd556e9ab053.gif) Could you consider to merge it?

codecov[bot] commented (Migrated from github.com)

Codecov Report

Merging #749 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #749      +/-   ##
==========================================
+ Coverage   39.00%   39.01%   +0.01%     
==========================================
  Files          73       73              
  Lines        9699     9699              
  Branches     2229     2229              
==========================================
+ Hits         3783     3784       +1     
- Misses       4753     4787      +34     
+ Partials     1163     1128      -35

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/749?src=pr&el=h1) Report > Merging [#749](https://codecov.io/gh/Plume-org/Plume/pull/749?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/4e43c676b421c8f38485196c04ffb333f4439898&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #749 +/- ## ========================================== + Coverage 39.00% 39.01% +0.01% ========================================== Files 73 73 Lines 9699 9699 Branches 2229 2229 ========================================== + Hits 3783 3784 +1 - Misses 4753 4787 +34 + Partials 1163 1128 -35 ```

elegaanz (Migrated from github.com) approved these changes

KitaitiMakoto commented (Migrated from github.com)

Thanks!

kiwii referenced this issue from a commit

Move stylesheets for header from _global.sccss to _header.scss (#749)

Reviewers

The pull request has been merged as c217e5e9b3.

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b menu-icon master

git pull origin menu-icon

Step 2:

Merge the changes and update on Forgejo.

git checkout master

git merge --no-ff menu-icon

git push origin master

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Loading…

There is no content yet.

Labels Milestones

Move stylesheets for header from _global.sccss to _header.scss #749

Codecov Report

Reviewers

Step 1:

Step 2: