Make blocklist deletion possible #750

Merged
KitaitiMakoto merged 1 commits from blocklist-deletion into master 4 years ago
KitaitiMakoto commented 4 years ago (Migrated from github.com)

Hi,

I found simple condition check miss and fixed it.

Hi, I found simple condition check miss and fixed it.
codecov[bot] commented 4 years ago (Migrated from github.com)

Codecov Report

Merging #750 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #750      +/-   ##
==========================================
- Coverage   39.01%   39.00%   -0.02%     
==========================================
  Files          73       73              
  Lines        9699     9699              
  Branches     2229     2229              
==========================================
- Hits         3784     3783       -1     
+ Misses       4787     4753      -34     
- Partials     1128     1163      +35     
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/750?src=pr&el=h1) Report > Merging [#750](https://codecov.io/gh/Plume-org/Plume/pull/750?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/c217e5e9b342304740623a4e9a8c3f189cea6f1c&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #750 +/- ## ========================================== - Coverage 39.01% 39.00% -0.02% ========================================== Files 73 73 Lines 9699 9699 Branches 2229 2229 ========================================== - Hits 3784 3783 -1 + Misses 4787 4753 -34 - Partials 1128 1163 +35 ```
elegaanz (Migrated from github.com) approved these changes 4 years ago
elegaanz (Migrated from github.com) left a comment

Nice catch! Thank you

Nice catch! Thank you
KitaitiMakoto commented 4 years ago (Migrated from github.com)

Thanks!

Thanks!
kiwii referenced this issue from a commit 4 years ago

Reviewers

The pull request has been merged as ac7a05b09a.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b blocklist-deletion master
git pull origin blocklist-deletion

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff blocklist-deletion
git push origin master
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#750
Loading…
There is no content yet.