remove dependency on runtime-fmt #773

已合并

OddBloke 已将来自 bug/769 的 1 提交合并入 master

2020-05-18 18:18:08 +00:00

OddBloke 评论于

2020-05-18 03:38:57 +00:00

(从 github.com 迁移)

Per the issue, "runtime-fmt uses perma-unstable rust APIs and is
therefore susceptible to breakage".

This replaces the two calls to rt_format! with .replace() and drops the
dependency.

Fixes #769

Per the issue, "runtime-fmt uses perma-unstable rust APIs and is therefore susceptible to breakage". This replaces the two calls to rt_format! with .replace() and drops the dependency. Fixes #769

OddBloke 评论于

2020-05-18 03:40:31 +00:00

(从 github.com 迁移)

I tested that this is the appropriate replace() invocation by writing the following temporary test:

mod tests {
    #[test]
    fn temp_test() {
        let template = format!(
            "https://{}/remote_interact?target={{uri}}",
            "some_public_domain"
        );
        assert_eq!(
            template.replace("{uri}", "substitute"),
            rt_format!(template, uri = "substitute").unwrap()
        );
    }
}

I tested that this is the appropriate `replace()` invocation by writing the following temporary test: ```rust mod tests { #[test] fn temp_test() { let template = format!( "https://{}/remote_interact?target={{uri}}", "some_public_domain" ); assert_eq!( template.replace("{uri}", "substitute"), rt_format!(template, uri = "substitute").unwrap() ); } } ```

codecov[bot] 评论于

2020-05-18 04:08:58 +00:00

(从 github.com 迁移)

Codecov Report

Merging #773 into master will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #773   +/-   ##
=======================================
  Coverage   38.96%   38.96%           
=======================================
  Files          73       73           
  Lines        9730     9730           
  Branches     2227     2227           
=======================================
  Hits         3791     3791           
  Misses       4885     4885           
  Partials     1054     1054

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/773?src=pr&el=h1) Report > Merging [#773](https://codecov.io/gh/Plume-org/Plume/pull/773?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/197f0d7ecd008d6c319e4c566cfebf48cb228a90&el=desc) will **not change** coverage. > The diff coverage is `0.00%`. ```diff @@ Coverage Diff @@ ## master #773 +/- ## ======================================= Coverage 38.96% 38.96% ======================================= Files 73 73 Lines 9730 9730 Branches 2227 2227 ======================================= Hits 3791 3791 Misses 4885 4885 Partials 1054 1054 ```

igalic (从 github.com 迁移) 于 2020-05-18 05:24:33 +00:00 批准此合并请求