remove dependency on runtime-fmt #773

已合併

OddBloke 將 1 次提交從 bug/769 合併至 master

OddBloke 已留言 (已從 github.com 遷移)

Per the issue, "runtime-fmt uses perma-unstable rust APIs and is
therefore susceptible to breakage".

This replaces the two calls to rt_format! with .replace() and drops the
dependency.

Fixes #769

Per the issue, "runtime-fmt uses perma-unstable rust APIs and is therefore susceptible to breakage". This replaces the two calls to rt_format! with .replace() and drops the dependency. Fixes #769

OddBloke 已留言 (已從 github.com 遷移)

I tested that this is the appropriate replace() invocation by writing the following temporary test:

mod tests {
    #[test]
    fn temp_test() {
        let template = format!(
            "https://{}/remote_interact?target={{uri}}",
            "some_public_domain"
        );
        assert_eq!(
            template.replace("{uri}", "substitute"),
            rt_format!(template, uri = "substitute").unwrap()
        );
    }
}

I tested that this is the appropriate `replace()` invocation by writing the following temporary test: ```rust mod tests { #[test] fn temp_test() { let template = format!( "https://{}/remote_interact?target={{uri}}", "some_public_domain" ); assert_eq!( template.replace("{uri}", "substitute"), rt_format!(template, uri = "substitute").unwrap() ); } } ```

codecov[bot] 已留言 (已從 github.com 遷移)

Codecov Report

Merging #773 into master will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #773   +/-   ##
=======================================
  Coverage   38.96%   38.96%           
=======================================
  Files          73       73           
  Lines        9730     9730           
  Branches     2227     2227           
=======================================
  Hits         3791     3791           
  Misses       4885     4885           
  Partials     1054     1054

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/773?src=pr&el=h1) Report > Merging [#773](https://codecov.io/gh/Plume-org/Plume/pull/773?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/197f0d7ecd008d6c319e4c566cfebf48cb228a90&el=desc) will **not change** coverage. > The diff coverage is `0.00%`. ```diff @@ Coverage Diff @@ ## master #773 +/- ## ======================================= Coverage 38.96% 38.96% ======================================= Files 73 73 Lines 9730 9730 Branches 2227 2227 ======================================= Hits 3791 3791 Misses 4885 4885 Partials 1054 1054 ```

igalic (已從 github.com 遷移) 核可了這些變更

igalic (已從 github.com 遷移) 留下了回應

👍

OddBloke 已留言 (已從 github.com 遷移)

Thanks for the merge!

kiwii 在提交中關聯了這個問題

remove dependency on runtime-fmt (#773) Per the issue, "runtime-fmt uses perma-unstable rust APIs and is therefore susceptible to breakage". This replaces the two calls to rt_format! with .replace() and drops the dependency. Fixes #769

審核者

此合併請求已被合併為 efb76a3c17。

您也可以查看命令列指南。

第一步：

在您的儲存庫中切換到新分支並測試變更。

git checkout -b bug/769 master

git pull origin bug/769

第二步：

合併變更並更新到 Forgejo。

git checkout master

git merge --no-ff bug/769

git push origin master

登入才能加入這對話。

沒有審核者

未選擇里程碑

沒有負責人

1 參與者

通知

截止日期

截止日期無效或超出範圍，請使用「yyyy-mm-dd」的格式。

未設定截止日期。

先決條件

未設定先決條件。

載入中…

尚未有任何內容

標籤 里程碑

remove dependency on runtime-fmt #773

Codecov Report

審核者

第一步：

第二步：

標籤里程碑