cargo release helper #790

Fechado

igalic quer aplicar o merge de 50 commits de igalic/fix/cargo-release-helper em master

igalic comentou (Migrado de github.com)

add support for cargo-release
add & backfill Changelog!

how to use?

cargo release --dry-run --workspace minor

- add support for [cargo-release](https://github.com/sunng87/cargo-release) - add & backfill Changelog! ---- how to use? ```shell cargo release --dry-run --workspace minor ```

codecov[bot] comentou (Migrado de github.com)

Codecov Report

Merging #790 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #790      +/-   ##
==========================================
+ Coverage   39.09%   39.11%   +0.02%     
==========================================
  Files          73       73              
  Lines        9756     9756              
  Branches     2233     2233              
==========================================
+ Hits         3814     3816       +2     
  Misses       4885     4885              
+ Partials     1057     1055       -2

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/790?src=pr&el=h1) Report > Merging [#790](https://codecov.io/gh/Plume-org/Plume/pull/790?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/d99b42582d7a5a8c8087b6ebe067b944cae0c294&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #790 +/- ## ========================================== + Coverage 39.09% 39.11% +0.02% ========================================== Files 73 73 Lines 9756 9756 Branches 2233 2233 ========================================== + Hits 3814 3816 +2 Misses 4885 4885 + Partials 1057 1055 -2 ```

igalic comentou (Migrado de github.com)

uh… will we need to add it as development dependency?

elegaanz (Migrado de github.com) revisou

release.toml

elegaanz (Migrado de github.com) comentou

Shouldn't the repo URL be changed here?

elegaanz comentou (Migrado de github.com)

Also, maybe we could unify the headers in the changelog to follow what https://keepachangelog.com/ recommends, to keep it coherent.

And for the development dependency, I don't think so. It should be documented here that people who want to publish a new release should use this tool tho.

Also, maybe we could unify the headers in the changelog to follow what https://keepachangelog.com/ recommends, to keep it coherent. And for the development dependency, I don't think so. It should be documented [here](https://docs.joinplu.me/organization/release-process/) that people who want to publish a new release should use this tool tho.

👍 1

igalic (Migrado de github.com) revisou

release.toml

igalic (Migrado de github.com) comentou

how?

elegaanz (Migrado de github.com) revisou

release.toml

elegaanz (Migrado de github.com) comentou

To something like https://github.com/Plume-org/Plume/compare/{{tag_name}}...HEAD, so that the changelog links to our commit history.

To something like `https://github.com/Plume-org/Plume/compare/{{tag_name}}...HEAD`, so that the changelog links to our commit history.

elegaanz (Migrado de github.com) revisou

release.toml

elegaanz (Migrado de github.com) comentou

Also, is there a  somewhere in the changelog you added? I can't find it.

Also, is there a `` somewhere in the changelog you added? I can't find it.

igalic comentou (Migrado de github.com)

n. b. : i've back-filled the changelog by copy-pasting the text from our github releases page

for the future of the changelog, i absolutely agree

n. b. : i've back-filled the changelog by copy-pasting the text from our github releases page for the future of the changelog, i absolutely agree

elegaanz comentou (Migrado de github.com)

I know you copied what is on GitHub, but maybe we could change this text? Would it be a problem to have texts that are a bit different on Github and in the changelog? I would prefer to have the whole changelog have the same format (but that's arguable).

elegaanz comentou (Migrado de github.com)

Also, could it be possible to add pre-release-hook to run crowdin pull (I don't remember the exact arguments, but basically : the command to pull the latest version of translations)? Or do you think it should be done manually before running cargo release?

Also, could it be possible to add `pre-release-hook` to run `crowdin pull` (I don't remember the exact arguments, but basically : the command to pull the latest version of translations)? Or do you think it should be done manually before running `cargo release`?

igalic comentou (Migrado de github.com)

I know you copied what is on GitHub, but maybe we could change this text? Would it be a problem to have texts that are a bit different on Github and in the changelog? I would prefer to have the whole changelog have the same format (but that's arguable).

the only problem was time and energy
y'all have access to write to this PR, so, please, by all means, help me!!

Also, could it be possible to add pre-release-hook to run crowdin pull (I don't remember the exact arguments, but basically : the command to pull the latest version of translations)? Or do you think it should be done manually before running cargo release?

that's a very good idea!

how do i make it work?

◆ plume git:(fix/cargo-release-helper) ❯❯❯ crowdin pull
Project key is empty
✖ 1 plume git:(fix/cargo-release-helper) ❯❯❯

> I know you copied what is on GitHub, but maybe we could change this text? Would it be a problem to have texts that are a bit different on Github and in the changelog? I would prefer to have the whole changelog have the same format (but that's arguable). the only problem was time and energy y'all have access to write to this PR, so, please, by all means, help me!! > Also, could it be possible to add `pre-release-hook` to run `crowdin pull` (I don't remember the exact arguments, but basically : the command to pull the latest version of translations)? Or do you think it should be done manually before running `cargo release`? that's a very good idea! how do i make it work? ```shell ◆ plume git:(fix/cargo-release-helper) ❯❯❯ crowdin pull Project key is empty ✖ 1 plume git:(fix/cargo-release-helper) ❯❯❯ ```

elegaanz comentou (Migrado de github.com)

I don't remember how the Crowdin CLI works, I'll check that and edit the PR. I'll also edit the changelog.

❤️ 1

elegaanz comentou (Migrado de github.com)

So the translations should be pulled now, if you have a CROWDIN_API_KEY in your env. We should remember to document how to get one before making a release.

So the translations should be pulled now, if you have a `CROWDIN_API_KEY` in your env. We should remember to document how to get one before making a release.

igalic comentou (Migrado de github.com)

So the translations should be pulled now, if you have a CROWDIN_API_KEY in your env. We should remember to document how to get one before making a release.

let's create a doc issue right now, and link it here

> So the translations should be pulled now, if you have a `CROWDIN_API_KEY` in your env. We should remember to document how to get one before making a release. let's create a doc issue right now, and link it here

elegaanz comentou (Migrado de github.com)

https://github.com/Plume-org/docs/issues/88

igalic comentou (Migrado de github.com)

what about docker?

elegaanz comentou (Migrado de github.com)

I think the release should be automatic, I'll check.

elegaanz comentou (Migrado de github.com)

It is not, I'll a hook.

elegaanz comentou (Migrado de github.com)

The thing is, the docker tag needs to be pushed after the git tag, and there is no post-release-hook in cargo release, apparently.

So maybe we can document that this has to be done manually, and do it by hand for the moment?

The thing is, the docker tag needs to be pushed after the git tag, and there is no `post-release-hook` in cargo release, apparently. So maybe we can document that this has to be done manually, and do it by hand for the moment?

igalic comentou (Migrado de github.com)

or we could add docker tag to the CI build process, only on tag

igalic comentou (Migrado de github.com)

yunohost relies on docker, right?
and it's one of the platforms that we recommend, thru our installation guide

yunohost relies on docker, right? and it's one of *the* platforms that we recommend, thru our installation guide

elegaanz comentou (Migrado de github.com)

It doesn't, it uses Bash scripts. I'm not sure if it is better tho… 😅

It doesn't, it uses Bash scripts. I'm not sure if it is better tho… :sweat_smile:

igalic (Migrado de github.com) revisou

release.toml

igalic (Migrado de github.com) comentou

i didn't add it to our current changelog

KitaitiMakoto comentou

Proprietário

We can tag to Docker images automatically by setting automate build properly.

KitaitiMakoto comentou

Proprietário

A test succeeded:
(v0.5.1-test2 was pushed by plumeorg)

A test succeeded: ![](https://i.gyazo.com/c2a284d00404574c60588d00365f61b4.png) (v0.5.1-test2 was pushed by plumeorg)

KitaitiMakoto aprovou estas alterações

KitaitiMakoto deixou um comentário

Proprietário

Remaining issue is how do we notify YunoHost maintainer. It is not an issue of cargo helper (this pul request's theme) but an issue of CI. So this pull request is ready to be merged.

KitaitiMakoto referenciado este pull request

cargo release helper (again) #835

KitaitiMakoto referenciado este pull request

Remember to notify YunoHost maintainer on release #836

KitaitiMakoto comentou

Proprietário

Closed as #835

KitaitiMakoto fechou este pull request

Revisores

KitaitiMakoto aprovou estas alterações

Este pull request não pode ser reaberto porque o branch foi excluído.

Você também pode ver as instruções para a linha de comandos.

Passo 1:

No repositório do seu projeto, crie um novo branch e teste as alterações.

git checkout -b igalic/fix/cargo-release-helper master

git pull origin igalic/fix/cargo-release-helper

Passo 2:

Faça merge das alterações e atualize no Forgejo.

git checkout master

git merge --no-ff igalic/fix/cargo-release-helper

git push origin master

Acesse para participar desta conversação.

Sem revisor

Sem marco

Sem responsável

2 participante(s)

Notificações

Data limite

A data limite é inválida ou está fora do intervalo. Por favor, use o formato 'dd/mm/aaaa'.

Data limite não informada.

Dependências

Nenhuma dependência definida.

Carregando…

Ainda não há conteúdo.

Etiquetas Marcos

cargo release helper #790

Codecov Report

Revisores

Passo 1:

Passo 2: