cargo release helper #790

已关闭

igalic 请求将 50 次代码提交从 igalic/fix/cargo-release-helper 合并至 master

igalic 评论于 (从 github.com 迁移)

add support for cargo-release
add & backfill Changelog!

how to use?

cargo release --dry-run --workspace minor

- add support for [cargo-release](https://github.com/sunng87/cargo-release) - add & backfill Changelog! ---- how to use? ```shell cargo release --dry-run --workspace minor ```

codecov[bot] 评论于 (从 github.com 迁移)

Codecov Report

Merging #790 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #790      +/-   ##
==========================================
+ Coverage   39.09%   39.11%   +0.02%     
==========================================
  Files          73       73              
  Lines        9756     9756              
  Branches     2233     2233              
==========================================
+ Hits         3814     3816       +2     
  Misses       4885     4885              
+ Partials     1057     1055       -2

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/790?src=pr&el=h1) Report > Merging [#790](https://codecov.io/gh/Plume-org/Plume/pull/790?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/d99b42582d7a5a8c8087b6ebe067b944cae0c294&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #790 +/- ## ========================================== + Coverage 39.09% 39.11% +0.02% ========================================== Files 73 73 Lines 9756 9756 Branches 2233 2233 ========================================== + Hits 3814 3816 +2 Misses 4885 4885 + Partials 1057 1055 -2 ```

igalic 评论于 (从 github.com 迁移)

uh… will we need to add it as development dependency?

elegaanz (从 github.com 迁移) 评审于

release.toml

elegaanz (从 github.com 迁移) 评论于

Shouldn't the repo URL be changed here?

elegaanz 评论于 (从 github.com 迁移)

Also, maybe we could unify the headers in the changelog to follow what https://keepachangelog.com/ recommends, to keep it coherent.

And for the development dependency, I don't think so. It should be documented here that people who want to publish a new release should use this tool tho.

Also, maybe we could unify the headers in the changelog to follow what https://keepachangelog.com/ recommends, to keep it coherent. And for the development dependency, I don't think so. It should be documented [here](https://docs.joinplu.me/organization/release-process/) that people who want to publish a new release should use this tool tho.

👍 1

igalic (从 github.com 迁移) 评审于

release.toml

igalic (从 github.com 迁移) 评论于

how?

elegaanz (从 github.com 迁移) 评审于

release.toml

elegaanz (从 github.com 迁移) 评论于

To something like https://github.com/Plume-org/Plume/compare/{{tag_name}}...HEAD, so that the changelog links to our commit history.

To something like `https://github.com/Plume-org/Plume/compare/{{tag_name}}...HEAD`, so that the changelog links to our commit history.

elegaanz (从 github.com 迁移) 评审于

release.toml

elegaanz (从 github.com 迁移) 评论于

Also, is there a  somewhere in the changelog you added? I can't find it.

Also, is there a `` somewhere in the changelog you added? I can't find it.

igalic 评论于 (从 github.com 迁移)

n. b. : i've back-filled the changelog by copy-pasting the text from our github releases page

for the future of the changelog, i absolutely agree

n. b. : i've back-filled the changelog by copy-pasting the text from our github releases page for the future of the changelog, i absolutely agree

elegaanz 评论于 (从 github.com 迁移)

I know you copied what is on GitHub, but maybe we could change this text? Would it be a problem to have texts that are a bit different on Github and in the changelog? I would prefer to have the whole changelog have the same format (but that's arguable).

elegaanz 评论于 (从 github.com 迁移)

Also, could it be possible to add pre-release-hook to run crowdin pull (I don't remember the exact arguments, but basically : the command to pull the latest version of translations)? Or do you think it should be done manually before running cargo release?

Also, could it be possible to add `pre-release-hook` to run `crowdin pull` (I don't remember the exact arguments, but basically : the command to pull the latest version of translations)? Or do you think it should be done manually before running `cargo release`?

igalic 评论于 (从 github.com 迁移)

I know you copied what is on GitHub, but maybe we could change this text? Would it be a problem to have texts that are a bit different on Github and in the changelog? I would prefer to have the whole changelog have the same format (but that's arguable).

the only problem was time and energy
y'all have access to write to this PR, so, please, by all means, help me!!

Also, could it be possible to add pre-release-hook to run crowdin pull (I don't remember the exact arguments, but basically : the command to pull the latest version of translations)? Or do you think it should be done manually before running cargo release?

that's a very good idea!

how do i make it work?

◆ plume git:(fix/cargo-release-helper) ❯❯❯ crowdin pull
Project key is empty
✖ 1 plume git:(fix/cargo-release-helper) ❯❯❯

> I know you copied what is on GitHub, but maybe we could change this text? Would it be a problem to have texts that are a bit different on Github and in the changelog? I would prefer to have the whole changelog have the same format (but that's arguable). the only problem was time and energy y'all have access to write to this PR, so, please, by all means, help me!! > Also, could it be possible to add `pre-release-hook` to run `crowdin pull` (I don't remember the exact arguments, but basically : the command to pull the latest version of translations)? Or do you think it should be done manually before running `cargo release`? that's a very good idea! how do i make it work? ```shell ◆ plume git:(fix/cargo-release-helper) ❯❯❯ crowdin pull Project key is empty ✖ 1 plume git:(fix/cargo-release-helper) ❯❯❯ ```

elegaanz 评论于 (从 github.com 迁移)

I don't remember how the Crowdin CLI works, I'll check that and edit the PR. I'll also edit the changelog.

❤️ 1

elegaanz 评论于 (从 github.com 迁移)

So the translations should be pulled now, if you have a CROWDIN_API_KEY in your env. We should remember to document how to get one before making a release.

So the translations should be pulled now, if you have a `CROWDIN_API_KEY` in your env. We should remember to document how to get one before making a release.

igalic 评论于 (从 github.com 迁移)

So the translations should be pulled now, if you have a CROWDIN_API_KEY in your env. We should remember to document how to get one before making a release.

let's create a doc issue right now, and link it here

> So the translations should be pulled now, if you have a `CROWDIN_API_KEY` in your env. We should remember to document how to get one before making a release. let's create a doc issue right now, and link it here

elegaanz 评论于 (从 github.com 迁移)

https://github.com/Plume-org/docs/issues/88

igalic 评论于 (从 github.com 迁移)

what about docker?

elegaanz 评论于 (从 github.com 迁移)

I think the release should be automatic, I'll check.

elegaanz 评论于 (从 github.com 迁移)

It is not, I'll a hook.

elegaanz 评论于 (从 github.com 迁移)

The thing is, the docker tag needs to be pushed after the git tag, and there is no post-release-hook in cargo release, apparently.

So maybe we can document that this has to be done manually, and do it by hand for the moment?

The thing is, the docker tag needs to be pushed after the git tag, and there is no `post-release-hook` in cargo release, apparently. So maybe we can document that this has to be done manually, and do it by hand for the moment?

igalic 评论于 (从 github.com 迁移)

or we could add docker tag to the CI build process, only on tag

igalic 评论于 (从 github.com 迁移)

yunohost relies on docker, right?
and it's one of the platforms that we recommend, thru our installation guide

yunohost relies on docker, right? and it's one of *the* platforms that we recommend, thru our installation guide

elegaanz 评论于 (从 github.com 迁移)

It doesn't, it uses Bash scripts. I'm not sure if it is better tho… 😅

It doesn't, it uses Bash scripts. I'm not sure if it is better tho… :sweat_smile:

igalic (从 github.com 迁移) 评审于

release.toml

igalic (从 github.com 迁移) 评论于

i didn't add it to our current changelog

KitaitiMakoto 评论于

所有者

We can tag to Docker images automatically by setting automate build properly.

KitaitiMakoto 评论于

所有者

A test succeeded:
(v0.5.1-test2 was pushed by plumeorg)

A test succeeded: ![](https://i.gyazo.com/c2a284d00404574c60588d00365f61b4.png) (v0.5.1-test2 was pushed by plumeorg)

KitaitiMakoto 于批准此合并请求

KitaitiMakoto 留下了一条评论

所有者

Remaining issue is how do we notify YunoHost maintainer. It is not an issue of cargo helper (this pul request's theme) but an issue of CI. So this pull request is ready to be merged.

KitaitiMakoto "于引用了合并请求 "

cargo release helper (again) #835

KitaitiMakoto "于引用了合并请求 "

Remember to notify YunoHost maintainer on release #836

KitaitiMakoto 评论于

所有者

Closed as #835

KitaitiMakoto "于关闭此合并请求 "

评审人

KitaitiMakoto 于批准此合并请求

无法重新打开此合并请求，因为分支已删除。

你也可以查看命令行指令

第一步:

从你的仓库中签出一个新的分支并测试变更。

git checkout -b igalic/fix/cargo-release-helper master

git pull origin igalic/fix/cargo-release-helper

第二步：

合并变更并更新到 Forgejo 上

git checkout master

git merge --no-ff igalic/fix/cargo-release-helper

git push origin master

登录并参与到对话中。

无审核者

未选择里程碑

未指派成员

2 名参与者

通知

到期时间

到期日期无效或超出范围。请使用 'yyyy-mm-dd' 格式。

未设置到期时间。

依赖工单

没有设置依赖项。

正在加载...

这个人很懒，什么都没留下。

标签 里程碑

cargo release helper #790

Codecov Report

评审人

第一步:

第二步：

标签里程碑