Plume/Plume
9
18
Fork 24
Code Issues 177 Pull-Requests 8 Releases 8 Wiki Aktivität

WIP: Experiment: extract Searcher into an Actor #807

Geschlossen
igalic möchte 2 Commits von igalic/Plume:refactor/extract-searcher nach main zusammenführen
pullen von: igalic/Plume:refactor/extract-searcher
Ziel: Plume:main
Diskussion 1 Commits 2 Geänderte Dateien 4 +181 -2
igalic hat 2020-07-22 21:15:04 +00:00 kommentiert
Besitzer
Link kopieren

The goal of this pull request is to remove Searcher from PlumeRocket, as described in #799.
The strategy in this pull request is to use a riker actor and

  • Wrap Searcher & DbPool into an actor
  • create messages for add, delete, update
  • initialize actor system in main()
  • manage "actor system, so we have easy access to it
  • RequestGuard on ActorSystem, to allow access to it
  • instead of using &PlumeRocket.Searcher, use ActorSystem to send a message to our SearcherActor
The goal of this pull request is to remove `Searcher` from `PlumeRocket`, as described in #799. The strategy in this pull request is to use a riker actor and - Wrap Searcher & DbPool into an actor - create messages for add, delete, update - initialize actor system in `main()` - manage "actor system, so we have easy access to it - RequestGuard on ActorSystem, to allow access to it - instead of using `&PlumeRocket.Searcher`, use ActorSystem to send a message to our SearcherActor
igalic hat 2 Commits 2020-07-22 21:15:04 +00:00 hinzugefügt 
and implement AddDocument message!
This code compiles, but hasn't been put to use yet.
igalic hat 2020-07-26 19:37:41 +00:00 kommentiert
Autor
Besitzer
Link kopieren

closing in favour of #813

closing in favour of #813
igalic hat diesen Pull-Request 2020-07-26 19:37:41 +00:00 geschlossen

Pull-Request geschlossen

Bitte diesen Pull-Request wieder öffnen, um zusammenführen zu können.
Anmelden, um an der Diskussion teilzunehmen.
Reviewer
Keine Reviewer
Labels
Labels entfernen   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

Keine Label
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Meilenstein
Meilenstein entfernen
Keine Einträge
Kein Meilenstein
Projekte
Projekte löschen
Keine Einträge
Kein Projekt
Zuständige
Zuständige entfernen
Niemand zuständig
1 Beteiligter
Nachrichten
Fällig am
Das Fälligkeitsdatum ist ungültig oder außerhalb des zulässigen Bereichs. Bitte verwende das Format „jjjj-mm-tt“.

Kein Fälligkeitsdatum gesetzt.

Abhängigkeiten

Keine Abhängigkeiten gesetzt.

Referenz: Plume/Plume#807
Keine Beschreibung angegeben.
Branch „igalic/Plume:refactor/extract-searcher“ löschen

Das Löschen eines Branches ist permanent. Obwohl der Branch für eine kurze Zeit weiter existieren könnte, kann diese Aktion in den meisten Fällen NICHT rückgängig gemacht werden. Fortfahren?