Plume/Plume
9
18
Fork 24
Código Incidencias 177 Pull requests 8 Lanzamientos 8 Wiki Actividad

WIP: Experiment: extract Searcher into an Actor #807

Cerrada
igalic quiere fusionar 2 commits de igalic/Plume:refactor/extract-searcher en main
recuperar de: igalic/Plume:refactor/extract-searcher
fusionar en: Plume:main
Conversación 1 Commits 2 Archivos modificados 4 +181 -2
igalic comentado 2020-07-22 21:15:04 +00:00
Propietario
Copiar enlace

The goal of this pull request is to remove Searcher from PlumeRocket, as described in #799.
The strategy in this pull request is to use a riker actor and

  • Wrap Searcher & DbPool into an actor
  • create messages for add, delete, update
  • initialize actor system in main()
  • manage "actor system, so we have easy access to it
  • RequestGuard on ActorSystem, to allow access to it
  • instead of using &PlumeRocket.Searcher, use ActorSystem to send a message to our SearcherActor
The goal of this pull request is to remove `Searcher` from `PlumeRocket`, as described in #799. The strategy in this pull request is to use a riker actor and - Wrap Searcher & DbPool into an actor - create messages for add, delete, update - initialize actor system in `main()` - manage "actor system, so we have easy access to it - RequestGuard on ActorSystem, to allow access to it - instead of using `&PlumeRocket.Searcher`, use ActorSystem to send a message to our SearcherActor
igalic añadió 2 commits 2020-07-22 21:15:04 +00:00 
and implement AddDocument message!
This code compiles, but hasn't been put to use yet.
igalic comentado 2020-07-26 19:37:41 +00:00
Autoría
Propietario
Copiar enlace

closing in favour of #813

closing in favour of #813
igalic cerró este pull request 2020-07-26 19:37:41 +00:00

Se cerró la solicitud de incorporación

Vuelva a abrir este Pull Request para realizar una fusión.
Inicie sesión para unirse a esta conversación.
Revisores
No hay revisores
Etiquetas
Limpiar etiquetas   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

Sin etiquetas
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Limpiar Milestone
No hay elementos
Sin hito
Proyectos
Limpiar proyectos
No hay elementos
Ningún proyecto
Asignados
Limpiar asignados
Sin encargados
1 participante
Notificaciones
Fecha límite
La fecha límite es inválida o está fuera de rango. Por favor utiliza el formato "aaaa-mm-dd".

Fecha límite no definida.

Dependencias

No se han establecido dependencias.

Referencia: Plume/Plume#807
No se ha proporcionado una descripción.
Eliminar rama "igalic/Plume:refactor/extract-searcher "

Eliminar una rama es permanente. Aunque la rama eliminada puede continuar existiendo durante un corto tiempo antes de que sea eliminada, en la mayoría de los casos NO PUEDE deshacerse. ¿Continuar?