Plume/Plume
9
18
Forkkaa 24
Koodi Ongelmat 177 Vetopyynnöt 8 Julkaisut 8 Wiki Toiminta

WIP: Experiment: extract Searcher into an Actor #807

Suljettu
igalic haluaa yhdistää 2 committia lähteestä igalic/Plume:refactor/extract-searcher kohteeseen main
vedä kohteesta: igalic/Plume:refactor/extract-searcher
merge into: Plume:main
Keskustelu 1 Commitit 2 Muuttuneet tiedostot 4 +181 -2
igalic kommentoi 2020-07-22 21:15:04 +00:00
Omistaja
Kopioi linkki

The goal of this pull request is to remove Searcher from PlumeRocket, as described in #799.
The strategy in this pull request is to use a riker actor and

  • Wrap Searcher & DbPool into an actor
  • create messages for add, delete, update
  • initialize actor system in main()
  • manage "actor system, so we have easy access to it
  • RequestGuard on ActorSystem, to allow access to it
  • instead of using &PlumeRocket.Searcher, use ActorSystem to send a message to our SearcherActor
The goal of this pull request is to remove `Searcher` from `PlumeRocket`, as described in #799. The strategy in this pull request is to use a riker actor and - Wrap Searcher & DbPool into an actor - create messages for add, delete, update - initialize actor system in `main()` - manage "actor system, so we have easy access to it - RequestGuard on ActorSystem, to allow access to it - instead of using `&PlumeRocket.Searcher`, use ActorSystem to send a message to our SearcherActor
igalic lisäsi 2 committia 2020-07-22 21:15:04 +00:00 
and implement AddDocument message!
This code compiles, but hasn't been put to use yet.
igalic kommentoi 2020-07-26 19:37:41 +00:00
Tekijä
Omistaja
Kopioi linkki

closing in favour of #813

closing in favour of #813
igalic closed this pull request 2020-07-26 19:37:41 +00:00

Vetopyyntö suljettu

Please reopen this pull request to perform a merge.
Kirjaudu sisään liittyäksesi keskusteluun.
Reviewers
No reviewers
Tunnisteet
Tyhjennä tunnisteet   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

Ei tunnisteita
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Merkkipaalu
Tyhjennä merkkipaalu
Ei kohteita
Ei merkkipaalua
Projektit
Clear projects
Ei kohteita
Ei projektia
Käsittelijä
Tyhjennä käsittelijä
Ei käsittelijää
1 osallistuja
Ilmoitukset
Määräpäivä
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

Määräpäivää ei ole asetettu.

Riippuvuudet

Riippuvuuksia ei asetettu.

Viittaus: Plume/Plume#807
Ei kuvausta.
Poista haara "igalic/Plume:refactor/extract-searcher"

Haaran poistaminen on pysyvä toimenpide. Vaikka poistettu haara voi jäädä olemaan lyhyeksi ajaksi, ennen kuin todellisesti poistetaan, poistoa EI VOI perua useimmiten. Jatketaanko?