Plume/Plume
9
18
Deriva 24
Codice Segnalazioni 177 Richieste di modifica 8 Rilasci 8 Wiki Attività

WIP: Experiment: extract Searcher into an Actor #807

Chiuso
igalic vuole unire 2 commit da igalic/Plume:refactor/extract-searcher a main
esegui un pull da: igalic/Plume:refactor/extract-searcher
unisci a: Plume:main
Conversazione 1 Commit 2 File modificati 4 +181 -2
igalic 2020-07-22 21:15:04 +00:00 ha commentato
Proprietario
Copia collegamento

The goal of this pull request is to remove Searcher from PlumeRocket, as described in #799.
The strategy in this pull request is to use a riker actor and

  • Wrap Searcher & DbPool into an actor
  • create messages for add, delete, update
  • initialize actor system in main()
  • manage "actor system, so we have easy access to it
  • RequestGuard on ActorSystem, to allow access to it
  • instead of using &PlumeRocket.Searcher, use ActorSystem to send a message to our SearcherActor
The goal of this pull request is to remove `Searcher` from `PlumeRocket`, as described in #799. The strategy in this pull request is to use a riker actor and - Wrap Searcher & DbPool into an actor - create messages for add, delete, update - initialize actor system in `main()` - manage "actor system, so we have easy access to it - RequestGuard on ActorSystem, to allow access to it - instead of using `&PlumeRocket.Searcher`, use ActorSystem to send a message to our SearcherActor
igalic ha aggiunto 2 commit 2020-07-22 21:15:04 +00:00 
and implement AddDocument message!
This code compiles, but hasn't been put to use yet.
igalic 2020-07-26 19:37:41 +00:00 ha commentato
Autore
Proprietario
Copia collegamento

closing in favour of #813

closing in favour of #813
igalic ha chiuso questa richiesta di modifica 2020-07-26 19:37:41 +00:00

Richiesta di modifica chiusa

Riapri questa pull request per effettuare l'unione.
Effettua l'accesso per partecipare alla conversazione.
Revisori
Nessun revisore
Etichette
Pulisci le etichette   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

Nessuna etichetta
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Traguardo
Milestone pulita
Nessun elemento
Nessuna pietra miliare
Progetti
Cancella progetti
Nessun elemento
Nessun progetto
Assegnatari
Cancella assegnatari
Nessun assegnatario
1 partecipante
Notifiche
Scadenza
La scadenza non è valida o fuori intervallo. Si prega di utilizzare il formato "aaaa-mm-dd".

Nessuna scadenza impostata.

Dipendenze

Nessuna dipendenza impostata.

Riferimento: Plume/Plume#807
Descrizione non fornita.
Elimina ramo "igalic/Plume:refactor/extract-searcher"

L'eliminazione di un ramo è definitiva. Nonostante il ramo eliminato potrebbe continuare ad esistere per un breve periodo di tempo prima di essere realmente eliminato, l'eliminazione NON PUÒ essere annullata in molti casi. Continuare?