Plume/Plume
9
18
포크 24
코드 이슈 177 풀 리퀘스트 8 릴리즈 8 위키 활동

WIP: Experiment: extract Searcher into an Actor #807

닫힘
igalic igalic/Plume:refactor/extract-searcher 에서 main 로 2개의 커밋들을 병합하려함
다음으로부터 풀: igalic/Plume:refactor/extract-searcher
병합하기: Plume:main
대화 1 커밋 2 파일 변경 4 +181 -2
igalic 코멘트함, 2020-07-22 21:15:04 +00:00
소유자
Copy link

The goal of this pull request is to remove Searcher from PlumeRocket, as described in #799.
The strategy in this pull request is to use a riker actor and

  • Wrap Searcher & DbPool into an actor
  • create messages for add, delete, update
  • initialize actor system in main()
  • manage "actor system, so we have easy access to it
  • RequestGuard on ActorSystem, to allow access to it
  • instead of using &PlumeRocket.Searcher, use ActorSystem to send a message to our SearcherActor
The goal of this pull request is to remove `Searcher` from `PlumeRocket`, as described in #799. The strategy in this pull request is to use a riker actor and - Wrap Searcher & DbPool into an actor - create messages for add, delete, update - initialize actor system in `main()` - manage "actor system, so we have easy access to it - RequestGuard on ActorSystem, to allow access to it - instead of using `&PlumeRocket.Searcher`, use ActorSystem to send a message to our SearcherActor
igalic added 2 commits 2020-07-22 21:15:04 +00:00 
and implement AddDocument message!
This code compiles, but hasn't been put to use yet.
igalic 코멘트함, 2020-07-26 19:37:41 +00:00
작성자
소유자
Copy link

closing in favour of #813

closing in favour of #813
igalic closed this pull request 2020-07-26 19:37:41 +00:00

Pull request closed

병합을 수행하려면 이 풀 리퀘스트를 다시 열어주세요.
로그인하여 이 대화에 참여하세요.
리뷰어
No reviewers
레이블
레이블 초기화   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

레이블 없음
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
마일스톤
마일스톤 초기화
No items
마일스톤 없음
Projects
Clear projects
No items
프로젝트 없음
담당자
담당자 초기화
담당자 없음
참가자 1명
알림
마감일
기한이 올바르지 않거나 범위를 벗어났습니다. "yyyy-mm-dd"형식을 사용해주십시오.

마감일이 설정되지 않았습니다.

전제조건

전제조건이 설정되지 않았습니다.

Reference: Plume/Plume#807
No description provided.
Delete branch "igalic/Plume:refactor/extract-searcher"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?