Plume
/
Plume
5
11
Vork 10
Code Kwesties 142 Pull-aanvragen 12 Publicaties 5 Wiki Activiteit
Labels Mijlpalen
Nieuwe Pull aanvraag

#807 WIP: Experiment: extract Searcher into an Actor

Closed
igalic wil 2 commits van igalic/Plume:refactor/extract-searcher samenvoegen met main
Discussie 1 Commits 2 Bestanden gewijzigd 4
igalic commented 9 maanden geleden

The goal of this pull request is to remove Searcher from PlumeRocket, as described in #799.
The strategy in this pull request is to use a riker actor and

  • Wrap Searcher & DbPool into an actor
  • create messages for add, delete, update
  • initialize actor system in main()
  • manage “actor system, so we have easy access to it
  • RequestGuard on ActorSystem, to allow access to it
  • instead of using &PlumeRocket.Searcher, use ActorSystem to send a message to our SearcherActor
The goal of this pull request is to remove `Searcher` from `PlumeRocket`, as described in #799. The strategy in this pull request is to use a riker actor and - Wrap Searcher & DbPool into an actor - create messages for add, delete, update - initialize actor system in `main()` - manage "actor system, so we have easy access to it - RequestGuard on ActorSystem, to allow access to it - instead of using `&PlumeRocket.Searcher`, use ActorSystem to send a message to our SearcherActor
igalic commented 9 maanden geleden
Eigenaar

closing in favour of #813

closing in favour of #813
igalic heeft deze pull request gesloten 9 maanden geleden
Heropen dit pull request aub om een een merge actie uit te voeren.
Log in om deel te nemen aan deze discussie.
Reviewers
Beoordeling aanvragen
Geen beoordelaars
Labels
Labels toepassen
Verwijder labels
A: API
Related to the REST API A: Backend
Code running on the server A: Federation
Stuff related to Federation A: Front-End
Related to the front-end A: I18N
Translations, and related code A: Meta
More about project management or code than the project itself A: Security Build
The building, or installation process of Plume C: Bug
Something isn't working C: Discussion
We need to talk C: Enhancement
New feature or request C: Feature
This is a new feature Compatibility
Compatibility with different browsers, readers and OS Dependency
Related to an external package that Plume uses Design
UI/UX related issues and PRs Documentation Good first issue
Good for newcomers Help welcome
Extra attention is needed Mobile
Issues affecting only mobile UX Rendering
How elements're rendered out for the end user S: Blocked
Something else needs to be fixed first S: Duplicate
This issue or pull request already exists S: Incomplete
This PR is not complete yet S: Instance specific
Issues concern a limited number of instances S: Invalid
This doesn't seem right S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio) S: Ready for review
This PR is ready to be reviewed Suggestion
Proposed ideas worth considering S: Voted on Loomio
This is issue has been created after a vote on Loomio S: Wontfix
This will not be worked on
Geen label
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Mijlpaal
Stel mijlpaal in
Verwijder mijlpaal
Geen items
Geen mijlpaal
Toegewezen aan
Gebruikers toewijzen
Verwijder toegewezen aan
Niet toegewezen
1 deelnemers
Notificaties
Vervaldatum

Geen vervaldatum ingesteld.

Afhankelijkheden

Deze pull-aanvraag heeft momenteel geen afhankelijkheden.

Schrijf Voorbeeld
Laden…
Annuleren
Opslaan
Er is nog geen inhoud.
Verwijder branch 'igalic/Plume:refactor/extract-searcher'

Het verwijderen van een branch is permanent. Het KAN NIET ongedaan gemaakt worden. Wil je toch doorgaan?

Nee
Ja