Plume
/
Plume
7
9
Forkuj 8
Kod Zgłoszenia 132 Oczekujące zmiany 13 Wydania 4 Wiki Aktywność
Etykiety Kamienie milowe
Nowy Pull Request

#807 WIP: Experiment: extract Searcher into an Actor

Zamknięty
igalic chce scalić 2 commity/ów z igalic/Plume:refactor/extract-searcher do main
Dyskusja 1 Commity 2 Zmodyfikowane pliki 4
igalic skomentował(-a) 4 miesięcy temu

The goal of this pull request is to remove Searcher from PlumeRocket, as described in #799.
The strategy in this pull request is to use a riker actor and

  • Wrap Searcher & DbPool into an actor
  • create messages for add, delete, update
  • initialize actor system in main()
  • manage “actor system, so we have easy access to it
  • RequestGuard on ActorSystem, to allow access to it
  • instead of using &PlumeRocket.Searcher, use ActorSystem to send a message to our SearcherActor
The goal of this pull request is to remove `Searcher` from `PlumeRocket`, as described in #799. The strategy in this pull request is to use a riker actor and - Wrap Searcher & DbPool into an actor - create messages for add, delete, update - initialize actor system in `main()` - manage "actor system, so we have easy access to it - RequestGuard on ActorSystem, to allow access to it - instead of using `&PlumeRocket.Searcher`, use ActorSystem to send a message to our SearcherActor
igalic skomentował(-a) 4 miesięcy temu
Właściciel

closing in favour of #813

closing in favour of #813
igalic zamknął(-ęła) ten pull request 4 miesięcy temu
Otwórz ponownie ten Pull Request, aby wykonać scalenie.
Zaloguj się, aby dołączyć do tej rozmowy.
Recenzenci
Poproś o recenzję
Brak recenzentów
Etykiety
Zastosuj etykiety
Wyczyść etykiety
A: API
Related to the REST API A: Backend
Code running on the server A: Federation
Stuff related to Federation A: Front-End
Related to the front-end A: I18N
Translations, and related code A: Meta
More about project management or code than the project itself A: Security Build
The building, or installation process of Plume C: Bug
Something isn't working C: Discussion
We need to talk C: Enhancement
New feature or request C: Feature
This is a new feature Compatibility
Compatibility with different browsers, readers and OS Dependency
Related to an external package that Plume uses Design
UI/UX related issues and PRs Documentation Good first issue
Good for newcomers Help welcome
Extra attention is needed Mobile
Issues affecting only mobile UX Rendering
How elements're rendered out for the end user S: Blocked
Something else needs to be fixed first S: Duplicate
This issue or pull request already exists S: Incomplete
This PR is not complete yet S: Instance specific
Issues concern a limited number of instances S: Invalid
This doesn't seem right S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio) S: Ready for review
This PR is ready to be reviewed Suggestion
Proposed ideas worth considering S: Voted on Loomio
This is issue has been created after a vote on Loomio S: Wontfix
This will not be worked on
Brak etykiety
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Kamień milowy
Ustaw kamień milowy
Wyczyść kamień milowy
Brak elementów
Brak kamienia milowego
Przypisani
Przypisz użytkowników
Usuń przypisanych
Brak przypisanych
Uczestnicy 1
Powiadomienia
Termin realizacji

Brak ustawionego terminu realizacji.

Zależności

Ten Pull Request nie zawiera w tej chwili żadnych zależności.

Napisz Podgląd
Ładowanie…
Anuluj
Zapisz
Nie ma jeszcze treści.
Usuń gałąź 'igalic/Plume:refactor/extract-searcher'

Usunięcie gałęzi jest trwałe i NIE MOŻE zostać cofnięte. Kontynuować?

Nie
Tak