Plume/Plume
9
18
Förgrening 24
Kod Ärenden 177 Pull-förfrågningar 8 Släpp 8 Wiki Aktiviteter

WIP: Experiment: extract Searcher into an Actor #807

Stängd
igalic vill sammanfoga 2 incheckningar från s[2]s in i main
pulla från: igalic/Plume:refactor/extract-searcher
merga in i: Plume:main
Konversation 1 Incheckningar 2 Ändrade filer 4 +181 -2
igalic kommenterad 2020-07-22 21:15:04 +00:00
Ägare
Kopiera länk

The goal of this pull request is to remove Searcher from PlumeRocket, as described in #799.
The strategy in this pull request is to use a riker actor and

  • Wrap Searcher & DbPool into an actor
  • create messages for add, delete, update
  • initialize actor system in main()
  • manage "actor system, so we have easy access to it
  • RequestGuard on ActorSystem, to allow access to it
  • instead of using &PlumeRocket.Searcher, use ActorSystem to send a message to our SearcherActor
The goal of this pull request is to remove `Searcher` from `PlumeRocket`, as described in #799. The strategy in this pull request is to use a riker actor and - Wrap Searcher & DbPool into an actor - create messages for add, delete, update - initialize actor system in `main()` - manage "actor system, so we have easy access to it - RequestGuard on ActorSystem, to allow access to it - instead of using `&PlumeRocket.Searcher`, use ActorSystem to send a message to our SearcherActor
igalic lade till 2 committer 2020-07-22 21:15:04 +00:00 
and implement AddDocument message!
This code compiles, but hasn't been put to use yet.
igalic kommenterad 2020-07-26 19:37:41 +00:00
Author
Ägare
Kopiera länk

closing in favour of #813

closing in favour of #813
igalic closed this pull request 2020-07-26 19:37:41 +00:00

Pull request closed

Vänligen återöppna denna Pull-förfrågan igen för att utföra sammanfogningen.
Logga in för att delta i denna konversation.
Granskare
Inga granskare
Etiketter
Rensa etiketter   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

Inga etiketter
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milsten
Rensa milstenar
Inga objekt
Ingen milstolpe
Projekt
Rensa projekt
Inga objekt
Inget projekt
Tilldelade
Rensa tilldelade
Inga tilldelade
1 participant
Notiser
Förfallodatum
Förfallodatumet är ogiltigt eller utanför gränserna. Använd formatet "åååå-mm-dd".

Inget förfallodatum satt.

Beroenden

No dependencies set.

Reference: Plume/Plume#807
No description provided.
Delete branch "igalic/Plume:refactor/extract-searcher"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?