plume-model: refactor Searcher to have its own DbPool #809

Chiuso
igalic vorrebbe unire 6 commit da igalic/Plume:refactor/extract-searcher-with-dbpool a main
igalic 1 anno fa ha commentato
Proprietario

This PR is another attempt at fixing #799

Instead of relying on a separate actor model, as described, we make use of the fact that DbPool is an Arc, and can be arbitrarily cloned, so we add it to Searcher. Further more, and db_pool.get() acts like sending a message to an Actor: if there are enough connections, the Pool gives us one, if not, tough luck!

this way, we don't need to pass along a conn into the searcher functions.
This should make splitting PlumeRocket up into its components a little easier.

This PR is another attempt at fixing #799 Instead of relying on a separate actor model, as described, we make use of the fact that DbPool is an `Arc`, and can be arbitrarily cloned, so we add it to `Searcher`. Further more, and `db_pool.get()` *acts* like sending a message to an Actor: if there are enough connections, the Pool gives us one, if not, tough luck! this way, we don't need to pass along a conn into the searcher functions. This should make splitting PlumeRocket up into its components a little easier.
igalic aggiunto 1 commit 1 anno fa
3b21eb766d
plume-model: refactor Searcher to have its own DbPool
kiwii hanno approvato queste modifiche 1 anno fa
kiwii lascia un commento

👌

let lang = schema.get_field("lang").unwrap();
let license = schema.get_field("license").unwrap();
let conn = self.dbpool.get().unwrap();
kiwii 1 anno fa ha commentato
Autore
Proprietario

I would prefer using ? instead of unwrap here.

I would prefer using `?` instead of `unwrap` here.
igalic 1 anno fa ha commentato
Autore
Proprietario

can you briefly explain why?

we use .unwrap() in all other lines.

can you briefly explain why? we use `.unwrap()` in all other lines.
kiwii 1 anno fa ha commentato
Autore
Proprietario

I think all the previous ones are safe: we now it can't panic because we control the search index schema, we know that these fields exist (even if Rust can't check this at comoile-time). Here, we may fail to get a DB connection from the pool for whatever reason, and I think we should make the error "go up", so that the web UI or the CLI can display a proper error.

I think all the previous ones are safe: we now it can't panic because we control the search index schema, we know that these fields exist (even if Rust can't check this at comoile-time). Here, we may fail to get a DB connection from the pool for whatever reason, and I think we should make the error "go up", so that the web UI or the CLI can display a proper error.
let searcher = self.reader.searcher();
let res = searcher.search(&query.into_query(), &collector).unwrap();
let conn = self.dbpool.get().unwrap();
kiwii 1 anno fa ha commentato
Autore
Proprietario

Same here.

Same here.
kiwii aggiunto 1 commit 1 anno fa
igalic revisionato 1 anno fa
igalic lascia un commento

👀

Io(std::io::Error),
MissingApProperty,
NotFound,
DbPool,
igalic 1 anno fa ha commentato
Autore
Proprietario

you're not trying to convert the original diesel::r2d2::Error?

you're not trying to convert the original `diesel::r2d2::Error`?
kiwii 1 anno fa ha commentato
Autore
Proprietario

It is a r2d2::Error, not the same as Diesel's one apparently. And I don't want to add another direct dependency in our Cargo.toml.

It is a `r2d2::Error`, not the same as Diesel's one apparently. And I don't want to add another direct dependency in our Cargo.toml.
igalic 1 anno fa ha commentato
Autore
Proprietario

gonna have to ask somebody how the heck this is happening

gonna have to ask somebody how the heck this is happening
let conn = match self.dbpool.get() {
Ok(c) => c,
Err(_) => return Err(Error::DbPool),
igalic 1 anno fa ha commentato
Autore
Proprietario

that means we won't know exactly why the pool didn't give us a connection

that means we won't know exactly why the pool didn't give us a connection
kiwii aggiunto 1 commit 1 anno fa
39ca7da3f0 Introduce Searcher::new
igalic revisionato 1 anno fa
igalic lascia un commento

🙋🏻‍♀️

///
/// The panic messages are normally explicit enough for a human to
/// understand how to fix the issue when they see it.
pub fn new(db_pool: DbPool) -> Arc<Self> {
igalic 1 anno fa ha commentato
Autore
Proprietario

why are we returning Arc<Self>?
this means our code needs to know exactly how it's going to be used

what about cli? does that use an Arc?

i would use this function to only return a Self
there's no need to init_pool, we just want a copy

we can create an initialize method, which tries to call open and create methods in the appropriate order with the error recovery, if that makes sense here

but as it stands, for a new function, this does too much

why are we returning `Arc<Self>`? this means our code needs to know exactly how it's going to be used what about cli? does that use an Arc? i would use this function to only return a Self there's no need to init_pool, we just want a copy we can create an initialize method, which tries to call open and create *methods* in the appropriate order with the error recovery, if that makes sense here but as it stands, for a new function, this does too much
kiwii aggiunto 1 commit 1 anno fa
igalic aggiunto 1 commit 1 anno fa
igalic force-pushed refactor/extract-searcher-with-dbpool da 9309ed279f a a5c81498b2 1 anno fa
igalic aggiunto 1 commit 1 anno fa
igalic 1 anno fa ha commentato
Autore
Proprietario

closing in favour of #813

closing in favour of #813
igalic closed this pull request 1 anno fa

Revisori

kiwii hanno approvato queste modifiche 1 anno fa
Riapri questa pull request per effettuare l'unione.
Effettua l'accesso per partecipare alla conversazione.
Nessun revisore
Nessuna milestone
Nessuna assegnatario
2 Partecipanti
Notifiche
Data di scadenza

Nessuna data di scadenza impostata.

Dipendenze

Questo problema attualmente non ha alcuna dipendenza.

Caricamento…
Non ci sono ancora contenuti.