plume-model: refactor Searcher to have its own DbPool #809
Fechado
igalic
quer aplicar o merge de 6 commits de igalic/Plume:refactor/extract-searcher-with-dbpool em main
Revisores
Etiquetas
Sem etiqueta
Marco
Sem marco
Responsáveis
Sem responsável
2 participante(s)
Notificações
Data limite
Data limite não informada.
Dependências
Atualmente este pull request não tem dependências.
Carregando…
Reference in new issue
Ainda não há conteúdo.
Excluir branch 'igalic/Plume:refactor/extract-searcher-with-dbpool'
A exclusão de uma branch é permanente. Isto NÃO PODERÁ ser desfeito. Continuar?
This PR is another attempt at fixing #799
Instead of relying on a separate actor model, as described, we make use of the fact that DbPool is an
Arc, and can be arbitrarily cloned, so we add it toSearcher. Further more, anddb_pool.get()acts like sending a message to an Actor: if there are enough connections, the Pool gives us one, if not, tough luck!this way, we don't need to pass along a conn into the searcher functions.
This should make splitting PlumeRocket up into its components a little easier.
👌
let lang = schema.get_field("lang").unwrap();let license = schema.get_field("license").unwrap();let conn = self.dbpool.get().unwrap();I would prefer using
?instead ofunwraphere.can you briefly explain why?
we use
.unwrap()in all other lines.I think all the previous ones are safe: we now it can't panic because we control the search index schema, we know that these fields exist (even if Rust can't check this at comoile-time). Here, we may fail to get a DB connection from the pool for whatever reason, and I think we should make the error "go up", so that the web UI or the CLI can display a proper error.
let searcher = self.reader.searcher();let res = searcher.search(&query.into_query(), &collector).unwrap();let conn = self.dbpool.get().unwrap();Same here.
👀
Io(std::io::Error),MissingApProperty,NotFound,DbPool,you're not trying to convert the original
diesel::r2d2::Error?It is a
r2d2::Error, not the same as Diesel's one apparently. And I don't want to add another direct dependency in our Cargo.toml.gonna have to ask somebody how the heck this is happening
let conn = match self.dbpool.get() {Ok(c) => c,Err(_) => return Err(Error::DbPool),that means we won't know exactly why the pool didn't give us a connection
🙋🏻♀️
////// The panic messages are normally explicit enough for a human to/// understand how to fix the issue when they see it.pub fn new(db_pool: DbPool) -> Arc<Self> {why are we returning
Arc<Self>?this means our code needs to know exactly how it's going to be used
what about cli? does that use an Arc?
i would use this function to only return a Self
there's no need to init_pool, we just want a copy
we can create an initialize method, which tries to call open and create methods in the appropriate order with the error recovery, if that makes sense here
but as it stands, for a new function, this does too much
closing in favour of #813
Revisores