9
18
Fork 24

proxy support #829

Manuell zusammengeführt
KitaitiMakoto hat 2 Commits von dr-bonez/Plume:feature/proxy nach main 2021-01-13 14:20:37 +00:00 zusammengeführt
Mitwirkender

Adds support for using a proxy for federation.
Motivation is for being able to support homeservers running as Tor hidden services.

Threading config information into plume-common is the only reason this pr isn't very low impact.

Adds support for using a proxy for federation. Motivation is for being able to support homeservers running as Tor hidden services. Threading config information into plume-common is the only reason this pr isn't very low impact.
Besitzer

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.
Besitzer

Sorry for very late reply.

What need proxy config is only ClientBuilder. How about to use CONFIG.proxy() directly in plume-common/src/activity_pub/mod.rs?

Sorry for very late reply. What need proxy config is only `ClientBuilder`. How about to use `CONFIG.proxy()` directly in `plume-common/src/activity_pub/mod.rs`?
Autor
Mitwirkender

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.
Autor
Mitwirkender

rebased

rebased
KitaitiMakoto hat die Änderungen 2021-01-13 14:16:23 +00:00 genehmigt
Besitzer

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
Besitzer

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
KitaitiMakoto hat Commit ec8c17482d in main 2021-01-13 14:20:37 +00:00 manuell zusammengeführt
Anmelden, um an der Diskussion teilzunehmen.
Keine Reviewer
Kein Meilenstein
Kein Projekt
Niemand zuständig
2 Beteiligte
Nachrichten
Fällig am
Das Fälligkeitsdatum ist ungültig oder außerhalb des zulässigen Bereichs. Bitte verwende das Format „jjjj-mm-tt“.

Kein Fälligkeitsdatum gesetzt.

Abhängigkeiten

Keine Abhängigkeiten gesetzt.

Referenz: Plume/Plume#829
Keine Beschreibung angegeben.