proxy support #829

Manually merged

KitaitiMakoto merged 2 commits from dr-bonez/Plume:feature/proxy into main

dr-bonez commented

Adds support for using a proxy for federation.
Motivation is for being able to support homeservers running as Tor hidden services.

Threading config information into plume-common is the only reason this pr isn't very low impact.

Adds support for using a proxy for federation. Motivation is for being able to support homeservers running as Tor hidden services. Threading config information into plume-common is the only reason this pr isn't very low impact.

KitaitiMakoto commented

Owner

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.

KitaitiMakoto commented

Owner

Sorry for very late reply.

What need proxy config is only ClientBuilder. How about to use CONFIG.proxy() directly in plume-common/src/activity_pub/mod.rs?

Sorry for very late reply. What need proxy config is only `ClientBuilder`. How about to use `CONFIG.proxy()` directly in `plume-common/src/activity_pub/mod.rs`?

dr-bonez commented

Poster

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.

dr-bonez commented

Poster

rebased

KitaitiMakoto approved these changes

KitaitiMakoto commented

Owner

Okay, I will merge. Thank you for your work!

KitaitiMakoto commented

Owner

Okay, I will merge. Thank you for your work!

KitaitiMakoto referenced this issue from a commit

Merge pull request 'proxy support' (#829) from dr-bonez/Plume:feature/proxy into main Reviewed-on: https://git.joinplu.me/Plume/Plume/pulls/829 Reviewed-by: KitaitiMakoto <kitaitimakoto@noreply@joinplu.me>

KitaitiMakoto merged commit ec8c17482d into main manually 3 years ago

Reviewers

KitaitiMakoto approved these changes

The pull request has been manually merged as ec8c17482d.

No reviewers

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Loading…

There is no content yet.

Labels Milestones

proxy support #829

Reviewers