proxy support #829

Fusionado manualmente
KitaitiMakoto fusionó 2 commits de dr-bonez/Plume:feature/proxy en main 2021-01-13 14:20:37 +00:00
Colaborador

Adds support for using a proxy for federation.
Motivation is for being able to support homeservers running as Tor hidden services.

Threading config information into plume-common is the only reason this pr isn't very low impact.

Adds support for using a proxy for federation. Motivation is for being able to support homeservers running as Tor hidden services. Threading config information into plume-common is the only reason this pr isn't very low impact.
Propietario

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.
Propietario

Sorry for very late reply.

What need proxy config is only ClientBuilder. How about to use CONFIG.proxy() directly in plume-common/src/activity_pub/mod.rs?

Sorry for very late reply. What need proxy config is only `ClientBuilder`. How about to use `CONFIG.proxy()` directly in `plume-common/src/activity_pub/mod.rs`?
Autoría
Colaborador

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.
Autoría
Colaborador

rebased

rebased
KitaitiMakoto aprobó estos cambios 2021-01-13 14:16:23 +00:00
Propietario

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
Propietario

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
KitaitiMakoto commit manualmente fusionado ec8c17482d en main 2021-01-13 14:20:37 +00:00
Inicie sesión para unirse a esta conversación.
No hay revisores
Sin hito
Ningún proyecto
Sin encargados
2 participantes
Notificaciones
Fecha límite
La fecha límite es inválida o está fuera de rango. Por favor utiliza el formato "aaaa-mm-dd".

Fecha límite no definida.

Dependencias

No se han establecido dependencias.

Referencia: Plume/Plume#829
No se ha proporcionado una descripción.