proxy support #829

Manuaalisesti yhdistetty
KitaitiMakoto yhdistetty 2 committia lähteestä dr-bonez/Plume:feature/proxy kohteeseen main 2021-01-13 14:20:37 +00:00
Contributor

Adds support for using a proxy for federation.
Motivation is for being able to support homeservers running as Tor hidden services.

Threading config information into plume-common is the only reason this pr isn't very low impact.

Adds support for using a proxy for federation. Motivation is for being able to support homeservers running as Tor hidden services. Threading config information into plume-common is the only reason this pr isn't very low impact.
Omistaja

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.
Omistaja

Sorry for very late reply.

What need proxy config is only ClientBuilder. How about to use CONFIG.proxy() directly in plume-common/src/activity_pub/mod.rs?

Sorry for very late reply. What need proxy config is only `ClientBuilder`. How about to use `CONFIG.proxy()` directly in `plume-common/src/activity_pub/mod.rs`?
Tekijä
Contributor

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.
Tekijä
Contributor

rebased

rebased
KitaitiMakoto hyväksyi nämä muutokset 2021-01-13 14:16:23 +00:00
Omistaja

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
Omistaja

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
KitaitiMakoto manually merged commit ec8c17482d into main 2021-01-13 14:20:37 +00:00
Kirjaudu sisään liittyäksesi keskusteluun.
No reviewers
Ei merkkipaalua
Ei projektia
Ei käsittelijää
2 osallistujaa
Ilmoitukset
Määräpäivä
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

Määräpäivää ei ole asetettu.

Riippuvuudet

Riippuvuuksia ei asetettu.

Viittaus: Plume/Plume#829
Ei kuvausta.