Plume
/
Plume
6
10
Fork 9
Koodi Ongelmat 135 Pull-pyynnöt 11 Julkaisut 5 Wiki Toiminta
Tunnisteet Merkkipaalut
Uusi pull pyyntö

#829 proxy support

Yhdistetty
KitaitiMakoto yhdistetty 2 committia lähteestä dr-bonez/Plume:feature/proxy kohteeseen main 4 päivää sitten
Keskustelu 6 Commitit 2 Muuttuneet tiedostot 63
dr-bonez kommentoi 3 kuukautta sitten

Adds support for using a proxy for federation.
Motivation is for being able to support homeservers running as Tor hidden services.

Threading config information into plume-common is the only reason this pr isn’t very low impact.

Adds support for using a proxy for federation. Motivation is for being able to support homeservers running as Tor hidden services. Threading config information into plume-common is the only reason this pr isn't very low impact.
KitaitiMakoto kommentoi 1 kuukausi sitten
Omistaja

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.
KitaitiMakoto kommentoi 2 viikkoa sitten
Omistaja

Sorry for very late reply.

What need proxy config is only ClientBuilder. How about to use CONFIG.proxy() directly in plume-common/src/activity_pub/mod.rs?

Sorry for very late reply. What need proxy config is only `ClientBuilder`. How about to use `CONFIG.proxy()` directly in `plume-common/src/activity_pub/mod.rs`?
dr-bonez kommentoi 6 päivää sitten
Tekijä

I can’t. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can’t have 2 crates that depend on each other.

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.
dr-bonez kommentoi 6 päivää sitten
Tekijä

rebased

rebased
KitaitiMakoto hyväksyi nämä muutokset 4 päivää sitten
KitaitiMakoto kommentoi 4 päivää sitten
Omistaja

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
KitaitiMakoto kommentoi 4 päivää sitten
Omistaja

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
KitaitiMakoto merged commit ec8c17482d into main 4 päivää sitten

Reviewers

KitaitiMakoto hyväksyi nämä muutokset 4 päivää sitten
The pull request has been merged as ec8c17482d.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
 KitaitiMakoto
Tunnisteet
Apply labels
Tyhjennä tunnisteet
A: API
Related to the REST API A: Backend
Code running on the server A: Federation
Stuff related to Federation A: Front-End
Related to the front-end A: I18N
Translations, and related code A: Meta
More about project management or code than the project itself A: Security Build
The building, or installation process of Plume C: Bug
Something isn't working C: Discussion
We need to talk C: Enhancement
New feature or request C: Feature
This is a new feature Compatibility
Compatibility with different browsers, readers and OS Dependency
Related to an external package that Plume uses Design
UI/UX related issues and PRs Documentation Good first issue
Good for newcomers Help welcome
Extra attention is needed Mobile
Issues affecting only mobile UX Rendering
How elements're rendered out for the end user S: Blocked
Something else needs to be fixed first S: Duplicate
This issue or pull request already exists S: Incomplete
This PR is not complete yet S: Instance specific
Issues concern a limited number of instances S: Invalid
This doesn't seem right S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio) S: Ready for review
This PR is ready to be reviewed Suggestion
Proposed ideas worth considering S: Voted on Loomio
This is issue has been created after a vote on Loomio S: Wontfix
This will not be worked on
Ei tunnistetta
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Merkkipaalu
Aseta merkkipaalu
Tyhjennä merkkipaalu
No items
Ei merkkipaalua
Käsittelijä
Assign users
Tyhjennä käsittelijä
Ei käsittelijää
2 osallistujaa
Ilmoitukset
Määräpäivä

Määräpäivää ei asetettu.

Riippuvuudet

Tällä vetopyynnöllä ei tällä hetkellä ole riippuvuuksia.

Kirjoita Esikatselu
Ladataan…
Peruuta
Tallenna
Sisältöä ei vielä ole.
Poista haara 'dr-bonez/Plume:feature/proxy'

Deleting a branch is permanent. It CANNOT be undone. Continue?

Ei
Kyllä