proxy support #829

Fusionné manuellement

KitaitiMakoto a fusionné 2 révision(s) à partir de dr-bonez/Plume:feature/proxy vers main

2021-01-13 14:20:37 +00:00

dr-bonez a commenté

2020-10-13 20:24:32 +00:00

Contributeur

Adds support for using a proxy for federation.
Motivation is for being able to support homeservers running as Tor hidden services.

Threading config information into plume-common is the only reason this pr isn't very low impact.

Adds support for using a proxy for federation. Motivation is for being able to support homeservers running as Tor hidden services. Threading config information into plume-common is the only reason this pr isn't very low impact.

KitaitiMakoto a commenté

2020-12-06 17:38:04 +00:00

Propriétaire

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.

KitaitiMakoto a commenté

2021-01-02 16:50:37 +00:00

Propriétaire

Sorry for very late reply.

What need proxy config is only ClientBuilder. How about to use CONFIG.proxy() directly in plume-common/src/activity_pub/mod.rs?

Sorry for very late reply. What need proxy config is only `ClientBuilder`. How about to use `CONFIG.proxy()` directly in `plume-common/src/activity_pub/mod.rs`?

dr-bonez a commenté

2021-01-11 20:24:33 +00:00

Auteur

Contributeur

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.