#829 proxy support

Unito
KitaitiMakoto ha unito 2 commit da dr-bonez/Plume:feature/proxy a main 1 settimana fa
dr-bonez 3 mesi fa ha commentato

Adds support for using a proxy for federation.
Motivation is for being able to support homeservers running as Tor hidden services.

Threading config information into plume-common is the only reason this pr isn’t very low impact.

Adds support for using a proxy for federation. Motivation is for being able to support homeservers running as Tor hidden services. Threading config information into plume-common is the only reason this pr isn't very low impact.
KitaitiMakoto 1 mese fa ha commentato
Proprietario

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.
KitaitiMakoto 3 settimane fa ha commentato
Proprietario

Sorry for very late reply.

What need proxy config is only ClientBuilder. How about to use CONFIG.proxy() directly in plume-common/src/activity_pub/mod.rs?

Sorry for very late reply. What need proxy config is only `ClientBuilder`. How about to use `CONFIG.proxy()` directly in `plume-common/src/activity_pub/mod.rs`?
dr-bonez 1 settimana fa ha commentato
Autore

I can’t. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can’t have 2 crates that depend on each other.

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.
dr-bonez 1 settimana fa ha commentato
Autore

rebased

rebased
KitaitiMakoto hanno approvato queste modifiche 1 settimana fa
KitaitiMakoto 1 settimana fa ha commentato
Proprietario

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
KitaitiMakoto 1 settimana fa ha commentato
Proprietario

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
KitaitiMakoto merged commit ec8c17482d into main 1 settimana fa

Revisori

KitaitiMakoto hanno approvato queste modifiche 1 settimana fa
La pull request è stata unita come ec8c17482d.
Effettua l'accesso per partecipare alla conversazione.
Nessun revisore
Nessuna milestone
Nessuna assegnatario
2 Partecipanti
Notifiche
Data di scadenza

Nessuna data di scadenza impostata.

Dipendenze

Questo problema attualmente non ha alcuna dipendenza.

Caricamento…
Non ci sono ancora contenuti.