Plume/Plume
9
18
Deriva 24
Codice Segnalazioni 177 Richieste di modifica 8 Rilasci 8 Wiki Attività

proxy support #829

Unito manualmente
KitaitiMakoto ha unito 2 commit da dr-bonez/Plume:feature/proxy a main 2021-01-13 14:20:37 +00:00
Conversazione 6 Commit 2 File modificati 63 +23944 -21671
dr-bonez 2020-10-13 20:24:32 +00:00 ha commentato
Contributore
Copia collegamento

Adds support for using a proxy for federation.
Motivation is for being able to support homeservers running as Tor hidden services.

Threading config information into plume-common is the only reason this pr isn't very low impact.

Adds support for using a proxy for federation. Motivation is for being able to support homeservers running as Tor hidden services. Threading config information into plume-common is the only reason this pr isn't very low impact.
KitaitiMakoto 2020-12-06 17:38:04 +00:00 ha commentato
Proprietario
Copia collegamento

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.
KitaitiMakoto 2021-01-02 16:50:37 +00:00 ha commentato
Proprietario
Copia collegamento

Sorry for very late reply.

What need proxy config is only ClientBuilder. How about to use CONFIG.proxy() directly in plume-common/src/activity_pub/mod.rs?

Sorry for very late reply. What need proxy config is only `ClientBuilder`. How about to use `CONFIG.proxy()` directly in `plume-common/src/activity_pub/mod.rs`?
dr-bonez 2021-01-11 20:24:33 +00:00 ha commentato
Autore
Contributore
Copia collegamento

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.
dr-bonez 2021-01-11 20:34:33 +00:00 ha commentato
Autore
Contributore
Copia collegamento

rebased

rebased
KitaitiMakoto hanno approvato queste modifiche 2021-01-13 14:16:23 +00:00
KitaitiMakoto 2021-01-13 14:18:12 +00:00 ha commentato
Proprietario
Copia collegamento

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
KitaitiMakoto 2021-01-13 14:19:50 +00:00 ha commentato
Proprietario
Copia collegamento

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
KitaitiMakoto ha fuso manualmente il commit ec8c17482d in main 2021-01-13 14:20:37 +00:00
Effettua l'accesso per partecipare alla conversazione.
Revisori
Nessun revisore
KitaitiMakoto
Etichette
Pulisci le etichette   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

Nessuna etichetta
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Traguardo
Milestone pulita
Nessun elemento
Nessuna pietra miliare
Progetti
Cancella progetti
Nessun elemento
Nessun progetto
Assegnatari
Cancella assegnatari
Nessun assegnatario
2 partecipanti
Notifiche
Scadenza
La scadenza non è valida o fuori intervallo. Si prega di utilizzare il formato "aaaa-mm-dd".

Nessuna scadenza impostata.

Dipendenze

Nessuna dipendenza impostata.

Riferimento: Plume/Plume#829
Descrizione non fornita.
Elimina ramo "dr-bonez/Plume:feature/proxy"

L'eliminazione di un ramo è definitiva. Nonostante il ramo eliminato potrebbe continuare ad esistere per un breve periodo di tempo prima di essere realmente eliminato, l'eliminazione NON PUÒ essere annullata in molti casi. Continuare?