proxy support #829

Handmatig samengevoegd
KitaitiMakoto heeft 2 commits samengevoegd van dr-bonez/Plume:feature/proxy naar main 2021-01-13 14:20:37 +00:00
Bijdrager

Adds support for using a proxy for federation.
Motivation is for being able to support homeservers running as Tor hidden services.

Threading config information into plume-common is the only reason this pr isn't very low impact.

Adds support for using a proxy for federation. Motivation is for being able to support homeservers running as Tor hidden services. Threading config information into plume-common is the only reason this pr isn't very low impact.
Eigenaar

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.
Eigenaar

Sorry for very late reply.

What need proxy config is only ClientBuilder. How about to use CONFIG.proxy() directly in plume-common/src/activity_pub/mod.rs?

Sorry for very late reply. What need proxy config is only `ClientBuilder`. How about to use `CONFIG.proxy()` directly in `plume-common/src/activity_pub/mod.rs`?
Auteur
Bijdrager

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.
Auteur
Bijdrager

rebased

rebased
KitaitiMakoto heeft deze veranderingen 2021-01-13 14:16:23 +00:00 goedgekeurd
Eigenaar

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
Eigenaar

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
KitaitiMakoto commit ec8c17482d handmatig samengevoegd in main 2021-01-13 14:20:37 +00:00
Log in om deel te nemen aan deze discussie.
Geen beoordelaars
Geen mijlpaal
Geen project
Niet toegewezen
2 deelnemers
Notificaties
Vervaldatum
De deadline is ongeldig of buiten bereik. Gebruik het formaat "jjjj-mm-dd'.

Geen vervaldatum ingesteld.

Afhankelijkheden

Geen afhankelijkheden ingesteld.

Referentie: Plume/Plume#829
Geen beschrijving gegeven.