#829 proxy support

Samengevoegd
KitaitiMakoto heeft 2 commits samengevoegd van dr-bonez/Plume:feature/proxy naar main 1 week geleden

Adds support for using a proxy for federation.
Motivation is for being able to support homeservers running as Tor hidden services.

Threading config information into plume-common is the only reason this pr isn’t very low impact.

Adds support for using a proxy for federation. Motivation is for being able to support homeservers running as Tor hidden services. Threading config information into plume-common is the only reason this pr isn't very low impact.
KitaitiMakoto commented 1 maand geleden
Eigenaar

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.
KitaitiMakoto commented 3 weken geleden
Eigenaar

Sorry for very late reply.

What need proxy config is only ClientBuilder. How about to use CONFIG.proxy() directly in plume-common/src/activity_pub/mod.rs?

Sorry for very late reply. What need proxy config is only `ClientBuilder`. How about to use `CONFIG.proxy()` directly in `plume-common/src/activity_pub/mod.rs`?
dr-bonez commented 1 week geleden
Poster

I can’t. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can’t have 2 crates that depend on each other.

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.
dr-bonez commented 1 week geleden
Poster

rebased

rebased
KitaitiMakoto heeft deze veranderingen 1 week geleden goedgekeurd
KitaitiMakoto commented 1 week geleden
Eigenaar

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
KitaitiMakoto commented 1 week geleden
Eigenaar

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
KitaitiMakoto heeft commit ec8c17482d samengevoegd in main 1 week geleden

Reviewers

KitaitiMakoto heeft deze veranderingen 1 week geleden goedgekeurd
The pull request has been merged as ec8c17482d.
Log in om deel te nemen aan deze discussie.
Geen beoordelaars
Geen mijlpaal
Niet toegewezen
2 deelnemers
Notificaties
Vervaldatum

Geen vervaldatum ingesteld.

Afhankelijkheden

Deze pull-aanvraag heeft momenteel geen afhankelijkheden.

Laden…
Er is nog geen inhoud.