#829 proxy support

Scalone
KitaitiMakoto scala 2 commity/ów z dr-bonez/Plume:feature/proxy do main 1 tydzień temu
dr-bonez skomentował(-a) 3 miesięcy temu

Adds support for using a proxy for federation.
Motivation is for being able to support homeservers running as Tor hidden services.

Threading config information into plume-common is the only reason this pr isn’t very low impact.

Adds support for using a proxy for federation. Motivation is for being able to support homeservers running as Tor hidden services. Threading config information into plume-common is the only reason this pr isn't very low impact.
KitaitiMakoto skomentował(-a) 1 miesiąc temu
Właściciel

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.
KitaitiMakoto skomentował(-a) 3 tygodni temu
Właściciel

Sorry for very late reply.

What need proxy config is only ClientBuilder. How about to use CONFIG.proxy() directly in plume-common/src/activity_pub/mod.rs?

Sorry for very late reply. What need proxy config is only `ClientBuilder`. How about to use `CONFIG.proxy()` directly in `plume-common/src/activity_pub/mod.rs`?
dr-bonez skomentował(-a) 1 tydzień temu
Autor

I can’t. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can’t have 2 crates that depend on each other.

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.
dr-bonez skomentował(-a) 1 tydzień temu
Autor

rebased

rebased
KitaitiMakoto zatwierdza te zmiany 1 tydzień temu
KitaitiMakoto skomentował(-a) 1 tydzień temu
Właściciel

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
KitaitiMakoto skomentował(-a) 1 tydzień temu
Właściciel

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
KitaitiMakoto merged commit ec8c17482d into main 1 tydzień temu

Recenzenci

KitaitiMakoto zatwierdza te zmiany 1 tydzień temu
Pull Request został scalony jako ec8c17482d.
Zaloguj się, aby dołączyć do tej rozmowy.
Brak recenzentów
Brak kamienia milowego
Brak przypisanych
Uczestnicy 2
Powiadomienia
Termin realizacji

Brak ustawionego terminu realizacji.

Zależności

Ten Pull Request nie zawiera w tej chwili żadnych zależności.

Ładowanie…
Nie ma jeszcze treści.