Plume
/
Plume
8
16
Forkuj 22
Kod Zgłoszenia 174 Oczekujące zmiany 8 Wydania 8 Wiki Aktywność

Etykiety Kamienie milowe

proxy support #829

Ręcznie scalone
KitaitiMakoto scala 2 commity/ów z dr-bonez/Plume:feature/proxy do main 3 lat temu
Dyskusja 6 Commity 2 Zmodyfikowane pliki 63
dr-bonez skomentował(-a) 4 lat temu

Adds support for using a proxy for federation.
Motivation is for being able to support homeservers running as Tor hidden services.

Threading config information into plume-common is the only reason this pr isn't very low impact.

Adds support for using a proxy for federation. Motivation is for being able to support homeservers running as Tor hidden services. Threading config information into plume-common is the only reason this pr isn't very low impact.
KitaitiMakoto skomentował(-a) 3 lat temu
Właściciel

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.
KitaitiMakoto skomentował(-a) 3 lat temu
Właściciel

Sorry for very late reply.

What need proxy config is only ClientBuilder. How about to use CONFIG.proxy() directly in plume-common/src/activity_pub/mod.rs?

Sorry for very late reply. What need proxy config is only `ClientBuilder`. How about to use `CONFIG.proxy()` directly in `plume-common/src/activity_pub/mod.rs`?
dr-bonez skomentował(-a) 3 lat temu
Autor

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.
dr-bonez skomentował(-a) 3 lat temu
Autor

rebased

rebased
KitaitiMakoto zatwierdza te zmiany 3 lat temu
KitaitiMakoto skomentował(-a) 3 lat temu
Właściciel

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
KitaitiMakoto skomentował(-a) 3 lat temu
Właściciel

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
KitaitiMakoto merged commit ec8c17482d into main manually 3 lat temu

Recenzenci

KitaitiMakoto zatwierdza te zmiany 3 lat temu
The pull request has been manually merged as ec8c17482d.
Zaloguj się, aby dołączyć do tej rozmowy.
Recenzenci
Poproś o recenzję
Brak recenzentów
KitaitiMakoto
Etykiety
Zastosuj etykiety
Wyczyść etykiety   
A: API

Related to the REST API   
A: Backend

Code running on the server   
A: Federation

Stuff related to Federation   
A: Front-End

Related to the front-end   
A: I18N

Translations, and related code   
A: Meta

More about project management or code than the project itself   
A: Security
   
Build

The building, or installation process of Plume   
C: Bug

Something isn't working   
C: Discussion

We need to talk   
C: Enhancement

New feature or request   
C: Feature

This is a new feature   
Compatibility

Compatibility with different browsers, readers and OS   
Dependency

Related to an external package that Plume uses   
Design

UI/UX related issues and PRs   
Documentation
   
Good first issue

Good for newcomers   
Help welcome

Extra attention is needed   
Mobile

Issues affecting only mobile UX   
Rendering

How elements're rendered out for the end user   
S: Blocked

Something else needs to be fixed first   
S: Duplicate

This issue or pull request already exists   
S: Incomplete

This PR is not complete yet   
S: Instance specific

Issues concern a limited number of instances   
S: Invalid

This doesn't seem right   
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)   
S: Ready for review

This PR is ready to be reviewed   
Suggestion

Proposed ideas worth considering   
S: Voted on Loomio

This is issue has been created after a vote on Loomio   
S: Wontfix

This will not be worked on
Brak etykiety
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Kamień milowy
Ustaw kamień milowy
Wyczyść kamień milowy
Brak elementów
Brak kamienia milowego
Przypisani
Przypisz użytkowników
Usuń przypisanych
Brak przypisanych
Uczestnicy 2
Powiadomienia
Termin realizacji
Data realizacji jest niewłaściwa lub spoza zakresu. Użyj formatu 'yyyy-mm-dd'.

Brak ustawionego terminu realizacji.

Zależności

No dependencies set.

Reference: Plume/Plume#829
Napisz Podgląd
Ładowanie…
Anuluj
Zapisz
Nie ma jeszcze treści.
Usuń gałąź 'dr-bonez/Plume:feature/proxy'

Usunięcie gałęzi jest trwałe i NIE MOŻE zostać cofnięte. Kontynuować?

Nie
Tak