proxy support #829

Merge aplicado manualmente
KitaitiMakoto aplicou merge dos 2 commits de dr-bonez/Plume:feature/proxy em main 3 anos atrás

Adds support for using a proxy for federation.
Motivation is for being able to support homeservers running as Tor hidden services.

Threading config information into plume-common is the only reason this pr isn't very low impact.

Adds support for using a proxy for federation. Motivation is for being able to support homeservers running as Tor hidden services. Threading config information into plume-common is the only reason this pr isn't very low impact.
Proprietário

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.
Proprietário

Sorry for very late reply.

What need proxy config is only ClientBuilder. How about to use CONFIG.proxy() directly in plume-common/src/activity_pub/mod.rs?

Sorry for very late reply. What need proxy config is only `ClientBuilder`. How about to use `CONFIG.proxy()` directly in `plume-common/src/activity_pub/mod.rs`?
Autor

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.
Autor

rebased

rebased
KitaitiMakoto aprovou estas alterações 3 anos atrás
Proprietário

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
Proprietário

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
KitaitiMakoto aplicou o merge do commit ec8c17482d em main manualmente 3 anos atrás

Revisores

KitaitiMakoto aprovou estas alterações 3 anos atrás
O pull request foi aplicado manualmente como ec8c17482d.
Acesse para participar desta conversação.
Sem revisor
Sem marco
Sem responsável
2 participante(s)
Notificações
Data limite
A data limite é inválida ou está fora do intervalo. Por favor, use o formato 'dd/mm/aaaa'.

Data limite não informada.

Dependências

Nenhuma dependência definida.

Referência: Plume/Plume#829
Carregando…
Ainda não há conteúdo.