9
18
Derivar 24

proxy support #829

Integrado manualmente
KitaitiMakoto integrou 2 cometimento(s) do ramo dr-bonez/Plume:feature/proxy no ramo main 2021-01-13 14:20:37 +00:00
Contribuidor

Adds support for using a proxy for federation.
Motivation is for being able to support homeservers running as Tor hidden services.

Threading config information into plume-common is the only reason this pr isn't very low impact.

Adds support for using a proxy for federation. Motivation is for being able to support homeservers running as Tor hidden services. Threading config information into plume-common is the only reason this pr isn't very low impact.
Proprietário(a)

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.
Proprietário(a)

Sorry for very late reply.

What need proxy config is only ClientBuilder. How about to use CONFIG.proxy() directly in plume-common/src/activity_pub/mod.rs?

Sorry for very late reply. What need proxy config is only `ClientBuilder`. How about to use `CONFIG.proxy()` directly in `plume-common/src/activity_pub/mod.rs`?
Autor(a)
Contribuidor

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.
Autor(a)
Contribuidor

rebased

rebased
KitaitiMakoto aprovou estas modificações 2021-01-13 14:16:23 +00:00
Proprietário(a)

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
Proprietário(a)

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
KitaitiMakoto cometimento ec8c17482d integrado manualmente em main 2021-01-13 14:20:37 +00:00
Inicie a sessão para participar neste diálogo.
Sem revisores
Sem etapa
Nenhum planeamento
Sem encarregados
2 Participantes
Notificações
Data de vencimento
A data de vencimento é inválida ou está fora do intervalo permitido. Por favor, use o formato "aaaa-mm-dd".

Sem data de vencimento definida.

Dependências

Não estão definidas dependências.

Referência: Plume/Plume#829
Nenhuma descrição fornecida.