proxy support #829

Слито вручную
KitaitiMakoto слито 2 коммит(ов) из dr-bonez/Plume:feature/proxy в main 2021-01-13 14:20:37 +00:00
dr-bonez оставлен комментарий 2020-10-13 20:24:32 +00:00
Соавтор

Adds support for using a proxy for federation.
Motivation is for being able to support homeservers running as Tor hidden services.

Threading config information into plume-common is the only reason this pr isn't very low impact.

Adds support for using a proxy for federation. Motivation is for being able to support homeservers running as Tor hidden services. Threading config information into plume-common is the only reason this pr isn't very low impact.
KitaitiMakoto оставлен комментарий 2020-12-06 17:38:04 +00:00
Владелец

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.
KitaitiMakoto оставлен комментарий 2021-01-02 16:50:37 +00:00
Владелец

Sorry for very late reply.

What need proxy config is only ClientBuilder. How about to use CONFIG.proxy() directly in plume-common/src/activity_pub/mod.rs?

Sorry for very late reply. What need proxy config is only `ClientBuilder`. How about to use `CONFIG.proxy()` directly in `plume-common/src/activity_pub/mod.rs`?
dr-bonez оставлен комментарий 2021-01-11 20:24:33 +00:00
Автор
Соавтор

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.
dr-bonez оставлен комментарий 2021-01-11 20:34:33 +00:00
Автор
Соавтор

rebased

rebased
KitaitiMakoto изменения одобрены 2021-01-13 14:16:23 +00:00
KitaitiMakoto оставлен комментарий 2021-01-13 14:18:12 +00:00
Владелец

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
KitaitiMakoto оставлен комментарий 2021-01-13 14:19:50 +00:00
Владелец

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
KitaitiMakoto коммит ec8c17482d был вручную добавлен в main 2021-01-13 14:20:37 +00:00
Войдите, чтобы присоединиться к обсуждению.
Нет рецензентов
Нет этапа
Нет проекта
Нет назначенных
2 участников
Уведомления
Срок выполнения
Срок выполнения недействителен или находится за пределами допустимого диапазона. Пожалуйста, используйте формат «гггг-мм-дд».

Срок выполнения не установлен.

Зависимости

Зависимостей нет.

Ссылка: Plume/Plume#829
Описание отсутствует.